Created attachment 171044 [details] ktd examples of barcodes you can batch add to a course To recreate: - Go to staff client -> Course reserves - Create a course or go to an existing course - Add reserves to the course (will need at least 21 items to be able to go to a second page of results) - Go to the second page of results on the course details page - Click the Remove button next to a result - Notice how the button just makes the page move to the top
Created attachment 171239 [details] [review] Bug 37838: Fix broken remove button in course reserves To test: 1) Go to staff client -> Course reserves 2) Create a course or go to an existing course 3) Add reserves to the course (will need at least 21 items to be able to go to a second page of results) 4) Go to the second page of results on the course details page 5) Click the Remove button next to a result 6) Notice how the button just makes the page move to the top 7) Apply patch 8) Repeat steps 1-5 9) Notice how the remove button is working as expected Sponsored-by: Toi Ohomai Institute of Technology
Created attachment 171354 [details] [review] Bug 37838: Fix broken remove button in course reserves To test: 1) Go to staff client -> Course reserves 2) Create a course or go to an existing course 3) Add reserves to the course (will need at least 21 items to be able to go to a second page of results) 4) Go to the second page of results on the course details page 5) Click the Remove button next to a result 6) Notice how the button just makes the page move to the top 7) Apply patch 8) Repeat steps 1-5 9) Notice how the remove button is working as expected Sponsored-by: Toi Ohomai Institute of Technology Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
Created attachment 171805 [details] [review] Bug 37838: Fix broken remove button in course reserves To test: 1) Go to staff client -> Course reserves 2) Create a course or go to an existing course 3) Add reserves to the course (will need at least 21 items to be able to go to a second page of results) 4) Go to the second page of results on the course details page 5) Click the Remove button next to a result 6) Notice how the button just makes the page move to the top 7) Apply patch 8) Repeat steps 1-5 9) Notice how the remove button is working as expected Sponsored-by: Toi Ohomai Institute of Technology Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.x for upcoming 24.05.06
Conflicts on 23.11.x I needed ?
(In reply to Fridolin Somers from comment #6) > Conflicts on 23.11.x > I needed ? Up to you, I can rebase for 23.11 if you'd like?
(In reply to Wainui Witika-Park from comment #7) > (In reply to Fridolin Somers from comment #6) > > Conflicts on 23.11.x > > I needed ? > > Up to you, I can rebase for 23.11 if you'd like? yes please
(In reply to Fridolin Somers from comment #8) > (In reply to Wainui Witika-Park from comment #7) > > (In reply to Fridolin Somers from comment #6) > > > Conflicts on 23.11.x > > > I needed ? > > > > Up to you, I can rebase for 23.11 if you'd like? > > yes please Hi Fridolin, I tried to recreate it on 23.11 but the error doesn't exist there so you can ignore this bug for 23.11
Thanks a lot