Bug 37838 - Remove button broken on second page of course reserves item results
Summary: Remove button broken on second page of course reserves item results
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Course reserves (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Wainui Witika-Park
QA Contact: Laura Escamilla
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-05 04:35 UTC by Wainui Witika-Park
Modified: 2024-11-18 23:26 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.06
Circulation function:


Attachments
ktd examples of barcodes you can batch add to a course (363 bytes, text/plain)
2024-09-05 04:35 UTC, Wainui Witika-Park
Details
Bug 37838: Fix broken remove button in course reserves (1.63 KB, patch)
2024-09-10 03:09 UTC, Wainui Witika-Park
Details | Diff | Splinter Review
Bug 37838: Fix broken remove button in course reserves (1.69 KB, patch)
2024-09-11 19:16 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 37838: Fix broken remove button in course reserves (1.76 KB, patch)
2024-09-19 20:23 UTC, Laura Escamilla
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Wainui Witika-Park 2024-09-05 04:35:45 UTC
Created attachment 171044 [details]
ktd examples of barcodes you can batch add to a course

To recreate:

- Go to staff client -> Course reserves
- Create a course or go to an existing course
- Add reserves to the course (will need at least 21 items to be able to go to a second page of results)
- Go to the second page of results on the course details page
- Click the Remove button next to a result
- Notice how the button just makes the page move to the top
Comment 1 Wainui Witika-Park 2024-09-10 03:09:47 UTC
Created attachment 171239 [details] [review]
Bug 37838: Fix broken remove button in course reserves

To test:
1) Go to staff client -> Course reserves
2) Create a course or go to an existing course
3) Add reserves to the course (will need at least 21 items to be able to go to a second page of results)
4) Go to the second page of results on the course details page
5) Click the Remove button next to a result
6) Notice how the button just makes the page move to the top
7) Apply patch
8) Repeat steps 1-5
9) Notice how the remove button is working as expected

Sponsored-by: Toi Ohomai Institute of Technology
Comment 2 Biblibre Sandboxes 2024-09-11 19:16:40 UTC
Created attachment 171354 [details] [review]
Bug 37838: Fix broken remove button in course reserves

To test:
1) Go to staff client -> Course reserves
2) Create a course or go to an existing course
3) Add reserves to the course (will need at least 21 items to be able to go to a second page of results)
4) Go to the second page of results on the course details page
5) Click the Remove button next to a result
6) Notice how the button just makes the page move to the top
7) Apply patch
8) Repeat steps 1-5
9) Notice how the remove button is working as expected

Sponsored-by: Toi Ohomai Institute of Technology
Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
Comment 3 Laura Escamilla 2024-09-19 20:23:27 UTC
Created attachment 171805 [details] [review]
Bug 37838: Fix broken remove button in course reserves

To test:
1) Go to staff client -> Course reserves
2) Create a course or go to an existing course
3) Add reserves to the course (will need at least 21 items to be able to go to a second page of results)
4) Go to the second page of results on the course details page
5) Click the Remove button next to a result
6) Notice how the button just makes the page move to the top
7) Apply patch
8) Repeat steps 1-5
9) Notice how the remove button is working as expected

Sponsored-by: Toi Ohomai Institute of Technology
Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Comment 4 Katrin Fischer 2024-10-16 15:35:10 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 5 Lucas Gass (lukeg) 2024-11-18 23:26:27 UTC
Backported to 24.05.x for upcoming 24.05.06