Bug 37844

Summary: Remove C4::Members::DeleteUnverifiedOpacRegistrations
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: RESOLVED FIXED QA Contact: Kyle M Hall (khall) <kyle>
Severity: enhancement    
Priority: P5 - low CC: kyle, lucas, m.de.rooy, paul.derscheid, sukhmandeep.benipal
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:
Bug Depends on:    
Bug Blocks: 16846, 37845    
Attachments: Bug 37844: Remove C4::Members::DeleteUnverifiedOpacRegistrations
Bug 37844: Remove C4::Members::DeleteUnverifiedOpacRegistrations
Bug 37844: Remove C4::Members::DeleteUnverifiedOpacRegistrations
Bug 37844: Remove C4::Members::DeleteUnverifiedOpacRegistrations

Description Jonathan Druart 2024-09-05 14:52:22 UTC

    
Comment 1 Jonathan Druart 2024-09-05 14:54:50 UTC
Created attachment 171079 [details] [review]
Bug 37844: Remove C4::Members::DeleteUnverifiedOpacRegistrations
Comment 2 Jonathan Druart 2024-09-05 14:55:33 UTC
I haven't tested this patch enough to set it to NSO, but feel free to test if you want!
Comment 3 Jonathan Druart 2024-09-09 14:17:25 UTC
Created attachment 171204 [details] [review]
Bug 37844: Remove C4::Members::DeleteUnverifiedOpacRegistrations

This patch removes the subroutine
C4::Members::DeleteUnverifiedOpacRegistrations and use the
Koha::Objects->filter_by_last_update method that is used for the other
flag in this script.

Test plan:
Confirm that --del-unv-selfreg works the same before and after this
patch applied
Comment 4 Sukhmandeep 2024-09-26 18:12:48 UTC
Created attachment 172002 [details] [review]
Bug 37844: Remove C4::Members::DeleteUnverifiedOpacRegistrations

This patch removes the subroutine
C4::Members::DeleteUnverifiedOpacRegistrations and use the
Koha::Objects->filter_by_last_update method that is used for the other
flag in this script.

Test plan:
Confirm that --del-unv-selfreg works the same before and after this
patch applied

Signed-off-by: Sukhmandeep Benipal <sukhmandeep.benipal@inLibro.com>
Comment 5 Kyle M Hall (khall) 2024-09-26 18:29:39 UTC
Created attachment 172005 [details] [review]
Bug 37844: Remove C4::Members::DeleteUnverifiedOpacRegistrations

This patch removes the subroutine
C4::Members::DeleteUnverifiedOpacRegistrations and use the
Koha::Objects->filter_by_last_update method that is used for the other
flag in this script.

Test plan:
Confirm that --del-unv-selfreg works the same before and after this
patch applied

Signed-off-by: Sukhmandeep Benipal <sukhmandeep.benipal@inLibro.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Katrin Fischer 2024-10-21 13:12:44 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 7 Lucas Gass (lukeg) 2024-11-18 23:01:54 UTC
Enhancement, no 24.05.x backport