37844 – Remove C4::Members::DeleteUnverifiedOpacRegistrations

Bug 37844 - Remove C4::Members::DeleteUnverifiedOpacRegistrations

Summary: Remove C4::Members::DeleteUnverifiedOpacRegistrations

Status:	Passed QA

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Architecture, internals, and plumbing (show other bugs)
Version:	unspecified
Hardware:	All All

Importance:	P5 - low enhancement
Assignee:	Jonathan Druart
QA Contact:	Kyle M Hall (khall)

URL:
Keywords:

Depends on:
Blocks:	16846 37845
	Show dependency tree / graph

Reported:	2024-09-05 14:52 UTC by Jonathan Druart
Modified:	2024-09-26 18:29 UTC (History)
CC List:	4 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 37844: Remove C4::Members::DeleteUnverifiedOpacRegistrations (4.28 KB, patch) 2024-09-05 14:54 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 37844: Remove C4::Members::DeleteUnverifiedOpacRegistrations (4.55 KB, patch) 2024-09-09 14:17 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 37844: Remove C4::Members::DeleteUnverifiedOpacRegistrations (4.62 KB, patch) 2024-09-26 18:12 UTC, Sukhmandeep	Details \| Diff \| Splinter Review
Bug 37844: Remove C4::Members::DeleteUnverifiedOpacRegistrations (4.68 KB, patch) 2024-09-26 18:29 UTC, Kyle M Hall (khall)	Details \| Diff \| Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jonathan Druart 2024-09-05 14:52:22 UTC

Comment 1 Jonathan Druart 2024-09-05 14:54:50 UTC

Created attachment 171079 [details] [review]
Bug 37844: Remove C4::Members::DeleteUnverifiedOpacRegistrations

Comment 2 Jonathan Druart 2024-09-05 14:55:33 UTC

I haven't tested this patch enough to set it to NSO, but feel free to test if you want!

Comment 3 Jonathan Druart 2024-09-09 14:17:25 UTC

Created attachment 171204 [details] [review]
Bug 37844: Remove C4::Members::DeleteUnverifiedOpacRegistrations

This patch removes the subroutine
C4::Members::DeleteUnverifiedOpacRegistrations and use the
Koha::Objects->filter_by_last_update method that is used for the other
flag in this script.

Test plan:
Confirm that --del-unv-selfreg works the same before and after this
patch applied

Comment 4 Sukhmandeep 2024-09-26 18:12:48 UTC

Created attachment 172002 [details] [review]
Bug 37844: Remove C4::Members::DeleteUnverifiedOpacRegistrations

This patch removes the subroutine
C4::Members::DeleteUnverifiedOpacRegistrations and use the
Koha::Objects->filter_by_last_update method that is used for the other
flag in this script.

Test plan:
Confirm that --del-unv-selfreg works the same before and after this
patch applied

Signed-off-by: Sukhmandeep Benipal <sukhmandeep.benipal@inLibro.com>

Comment 5 Kyle M Hall (khall) 2024-09-26 18:29:39 UTC

Created attachment 172005 [details] [review]
Bug 37844: Remove C4::Members::DeleteUnverifiedOpacRegistrations

This patch removes the subroutine
C4::Members::DeleteUnverifiedOpacRegistrations and use the
Koha::Objects->filter_by_last_update method that is used for the other
flag in this script.

Test plan:
Confirm that --del-unv-selfreg works the same before and after this
patch applied

Signed-off-by: Sukhmandeep Benipal <sukhmandeep.benipal@inLibro.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>