Bug 37868

Summary: Remove C4::Reserves::ToggleSuspend
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: RESOLVED FIXED QA Contact: Tomás Cohen Arazi (tcohen) <tomascohen>
Severity: enhancement    
Priority: P5 - low CC: lucas, martin.renvoize, nick, ovezina, paul.derscheid, tomascohen
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:
Bug Depends on: 30856    
Bug Blocks: 17728    
Attachments: Bug 37868: Remove C4::Reserves::ToggleSuspend
Bug 37868: Remove C4::Reserves::ToggleSuspend
Bug 37868: Remove C4::Reserves::ToggleSuspend

Description Jonathan Druart 2024-09-09 13:06:42 UTC

    
Comment 1 Jonathan Druart 2024-09-09 13:14:58 UTC
Created attachment 171196 [details] [review]
Bug 37868: Remove C4::Reserves::ToggleSuspend

We can easily replace the calls by ->suspend_hold and ->resume.

Test plan:
No behaviour changes expected.
Confirm that you can still suspend and resume holds (OPAC+staff)
Comment 2 Olivier Vezina 2024-09-13 20:15:52 UTC
Created attachment 171501 [details] [review]
Bug 37868: Remove C4::Reserves::ToggleSuspend

We can easily replace the calls by ->suspend_hold and ->resume.

Test plan:
No behaviour changes expected.
Confirm that you can still suspend and resume holds (OPAC+staff)

Signed-off-by: Olivier V <olivier.vezina@inLibro.com>
Comment 3 Tomás Cohen Arazi (tcohen) 2024-10-01 14:14:47 UTC
Created attachment 172275 [details] [review]
Bug 37868: Remove C4::Reserves::ToggleSuspend

We can easily replace the calls by ->suspend_hold and ->resume.

Test plan:
No behaviour changes expected.
Confirm that you can still suspend and resume holds (OPAC+staff)

Signed-off-by: Olivier V <olivier.vezina@inLibro.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 4 Tomás Cohen Arazi (tcohen) 2024-10-01 14:15:26 UTC
- Simple change.
- QA scripts happy.
- Suspending with/without a date works as before.
Comment 5 Katrin Fischer 2024-10-21 13:12:51 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 6 Lucas Gass (lukeg) 2024-11-18 23:02:09 UTC
Enhancement, no 24.05.x backport