37868 – Remove C4::Reserves::ToggleSuspend

Bug 37868 - Remove C4::Reserves::ToggleSuspend

Summary: Remove C4::Reserves::ToggleSuspend

Status:	Passed QA

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Architecture, internals, and plumbing (show other bugs)
Version:	unspecified
Hardware:	All All

Importance:	P5 - low enhancement
Assignee:	Jonathan Druart
QA Contact:	Tomás Cohen Arazi (tcohen)

URL:
Keywords:

Depends on:	30856
Blocks:	17728
	Show dependency tree / graph

Reported:	2024-09-09 13:06 UTC by Jonathan Druart
Modified:	2024-10-08 09:06 UTC (History)
CC List:	5 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 37868: Remove C4::Reserves::ToggleSuspend (10.62 KB, patch) 2024-09-09 13:14 UTC, Jonathan Druart	Details \| Diff \| Splinter Review
Bug 37868: Remove C4::Reserves::ToggleSuspend (10.67 KB, patch) 2024-09-13 20:15 UTC, Olivier Vezina	Details \| Diff \| Splinter Review
Bug 37868: Remove C4::Reserves::ToggleSuspend (10.73 KB, patch) 2024-10-01 14:14 UTC, Tomás Cohen Arazi (tcohen)	Details \| Diff \| Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jonathan Druart 2024-09-09 13:06:42 UTC

Comment 1 Jonathan Druart 2024-09-09 13:14:58 UTC

Created attachment 171196 [details] [review]
Bug 37868: Remove C4::Reserves::ToggleSuspend

We can easily replace the calls by ->suspend_hold and ->resume.

Test plan:
No behaviour changes expected.
Confirm that you can still suspend and resume holds (OPAC+staff)

Comment 2 Olivier Vezina 2024-09-13 20:15:52 UTC

Created attachment 171501 [details] [review]
Bug 37868: Remove C4::Reserves::ToggleSuspend

We can easily replace the calls by ->suspend_hold and ->resume.

Test plan:
No behaviour changes expected.
Confirm that you can still suspend and resume holds (OPAC+staff)

Signed-off-by: Olivier V <olivier.vezina@inLibro.com>

Comment 3 Tomás Cohen Arazi (tcohen) 2024-10-01 14:14:47 UTC

Created attachment 172275 [details] [review]
Bug 37868: Remove C4::Reserves::ToggleSuspend

We can easily replace the calls by ->suspend_hold and ->resume.

Test plan:
No behaviour changes expected.
Confirm that you can still suspend and resume holds (OPAC+staff)

Signed-off-by: Olivier V <olivier.vezina@inLibro.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Comment 4 Tomás Cohen Arazi (tcohen) 2024-10-01 14:15:26 UTC

- Simple change.
- QA scripts happy.
- Suspending with/without a date works as before.