Description
Lucas Gass (lukeg)
2024-09-10 14:16:57 UTC
Created attachment 171256 [details] [review] Bug 37883: Add logged in branch available, other, and onloan counts Created attachment 171257 [details] [review] Bug 37883: Add ability to filter search results location column by logged in location Created attachment 171261 [details] [review] Bug 37883: Add ability to filter search results location column by logged in location To test: 1. Apply patch, restart_all, and regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) I also recommend clearing your browser cache. 2. Do a catalog search and notice the 'Show local items only' button above the "Location" column. 3. Click it to show information ( in that column ) that is only related to the branch you are currently logged in at. 4. In the same result set have some items that are checked out, withdrawn, lost, damaged, and notforlaon. 5. Play more with the search results and ensure everything is accurate. Created attachment 171286 [details] [review] Bug 37883: Add FilterSearchResultsByLoggedInBranch system preference Created attachment 171287 [details] [review] Bug 37883: Adjust template for new system preference To test: 0. Apply patch, restart_all, and regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) I also recommend clearing your browser cache. 1. Search fof the FilterSearchResultsByLoggedInBranch system preference and set it to 'Do'. 2. Do a catalog search and notice the 'Show local items only' button above the "Location" column. 3. Click it to show information ( in that column ) that is only related to the branch you are currently logged in at. 4. In the same result set have some items that are checked out, withdrawn, lost, damaged, and notforlaon. 5. Play more with the search results and ensure everything is accurate. 6. Set the FilterSearchResultsByLoggedInBranch system preference to 'Don't' and confirm that there is no button to filter by branch anymore. Created attachment 171289 [details] [review] Bug 37883: Use Cookie to remember last selection Created attachment 171291 [details] [review] Bug 37883: Minor fix-ups and perltidy Created attachment 171406 [details] [review] Bug 37883: Add logged in branch available, other, and onloan counts Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Created attachment 171407 [details] [review] Bug 37883: Add ability to filter search results location column by logged in location To test: 1. Apply patch, restart_all, and regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) I also recommend clearing your browser cache. 2. Do a catalog search and notice the 'Show local items only' button above the "Location" column. 3. Click it to show information ( in that column ) that is only related to the branch you are currently logged in at. 4. In the same result set have some items that are checked out, withdrawn, lost, damaged, and notforlaon. 5. Play more with the search results and ensure everything is accurate. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Created attachment 171408 [details] [review] Bug 37883: Add FilterSearchResultsByLoggedInBranch system preference Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Created attachment 171409 [details] [review] Bug 37883: Adjust template for new system preference To test: 0. Apply patch, restart_all, and regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) I also recommend clearing your browser cache. 1. Search fof the FilterSearchResultsByLoggedInBranch system preference and set it to 'Do'. 2. Do a catalog search and notice the 'Show local items only' button above the "Location" column. 3. Click it to show information ( in that column ) that is only related to the branch you are currently logged in at. 4. In the same result set have some items that are checked out, withdrawn, lost, damaged, and notforlaon. 5. Play more with the search results and ensure everything is accurate. 6. Set the FilterSearchResultsByLoggedInBranch system preference to 'Don't' and confirm that there is no button to filter by branch anymore. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Created attachment 171410 [details] [review] Bug 37883: Use Cookie to remember last selection Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Created attachment 171411 [details] [review] Bug 37883: Minor fix-ups and perltidy Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> We have been using Lucas' JS for this for a really long time now (I think we requested it in early 2023 when we migrated) and our library staff love it. It's especially helpful for consortia with many branches. Thanks Lucas! show_local_items - I don't think you need a cookie here, storing in localStorage should be enough. Created attachment 176697 [details] [review] Bug 37883: Use localStorage instead of cookies to remember selection Remove the localStorage's item on logout, see koha-tmpl/intranet-tmpl/prog/js/staff-global.js 426 function logOut() { Created attachment 177306 [details] [review] Bug 37883: Remove show_local_items from localStorage on logout Created attachment 177784 [details] [review] Bug 37883: Add logged in branch available, other, and onloan counts Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Created attachment 177785 [details] [review] Bug 37883: Add ability to filter search results location column by logged in location To test: 1. Apply patch, restart_all, and regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) I also recommend clearing your browser cache. 2. Do a catalog search and notice the 'Show local items only' button above the "Location" column. 3. Click it to show information ( in that column ) that is only related to the branch you are currently logged in at. 4. In the same result set have some items that are checked out, withdrawn, lost, damaged, and notforlaon. 5. Play more with the search results and ensure everything is accurate. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Created attachment 177786 [details] [review] Bug 37883: Add FilterSearchResultsByLoggedInBranch system preference Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Created attachment 177787 [details] [review] Bug 37883: Adjust template for new system preference To test: 0. Apply patch, restart_all, and regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) I also recommend clearing your browser cache. 1. Search fof the FilterSearchResultsByLoggedInBranch system preference and set it to 'Do'. 2. Do a catalog search and notice the 'Show local items only' button above the "Location" column. 3. Click it to show information ( in that column ) that is only related to the branch you are currently logged in at. 4. In the same result set have some items that are checked out, withdrawn, lost, damaged, and notforlaon. 5. Play more with the search results and ensure everything is accurate. 6. Set the FilterSearchResultsByLoggedInBranch system preference to 'Don't' and confirm that there is no button to filter by branch anymore. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Created attachment 177788 [details] [review] Bug 37883: Use Cookie to remember last selection Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Created attachment 177789 [details] [review] Bug 37883: Minor fix-ups and perltidy Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Created attachment 177790 [details] [review] Bug 37883: Use localStorage instead of cookies to remember selection Created attachment 177791 [details] [review] Bug 37883: Remove show_local_items from localStorage on logout There is one small problem when I auto rebased this with duplicate text. When I try to solve the problem and commit the pre-hook tidy changes hundreds of lines: 824 insertions(+), 659 deletions(-) Created attachment 178772 [details] [review] Bug 37883: Add logged in branch available, other, and onloan counts Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Created attachment 178773 [details] [review] Bug 37883: Add ability to filter search results location column by logged in location To test: 1. Apply patch, restart_all, and regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) I also recommend clearing your browser cache. 2. Do a catalog search and notice the 'Show local items only' button above the "Location" column. 3. Click it to show information ( in that column ) that is only related to the branch you are currently logged in at. 4. In the same result set have some items that are checked out, withdrawn, lost, damaged, and notforlaon. 5. Play more with the search results and ensure everything is accurate. Created attachment 178774 [details] [review] Bug 37883: Add FilterSearchResultsByLoggedInBranch system preference Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Created attachment 178775 [details] [review] Bug Bug 37883: Adjust template for new system preference Created attachment 178776 [details] [review] Bug 37883: Use localStorage to remember user selection Created attachment 178777 [details] [review] Bug 37883: A couple minor fixes to results.tt (In reply to Lucas Gass (lukeg) from comment #27) > There is one small problem when I auto rebased this with duplicate text. > When I try to solve the problem and commit the pre-hook tidy changes > hundreds of lines: > > 824 insertions(+), 659 deletions(-) Hi Lucas, were you able to resolve or get more information? Maybe you could share the result somewhere? (In reply to Katrin Fischer from comment #34) > (In reply to Lucas Gass (lukeg) from comment #27) > > There is one small problem when I auto rebased this with duplicate text. > > When I try to solve the problem and commit the pre-hook tidy changes > > hundreds of lines: > > > > 824 insertions(+), 659 deletions(-) > > Hi Lucas, were you able to resolve or get more information? Maybe you could > share the result somewhere? Hi Cait, no great insight here. I ended up rewriting my patches on current main. :) (In reply to Lucas Gass (lukeg) from comment #35) > (In reply to Katrin Fischer from comment #34) > > (In reply to Lucas Gass (lukeg) from comment #27) > > > There is one small problem when I auto rebased this with duplicate text. > > > When I try to solve the problem and commit the pre-hook tidy changes > > > hundreds of lines: > > > > > > 824 insertions(+), 659 deletions(-) > > > > Hi Lucas, were you able to resolve or get more information? Maybe you could > > share the result somewhere? > > Hi Cait, no great insight here. I ended up rewriting my patches on current > main. :) Just trying to nail down the "glitches" we find so that we can improve on them. If you run into it again, please let us know! Created attachment 179688 [details] [review] Bug 37883: Add logged in branch available, other, and onloan counts Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Created attachment 179689 [details] [review] Bug 37883: Add ability to filter search results location column by logged in location To test: 1. Apply patch, restart_all, and regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) I also recommend clearing your browser cache. 2. Do a catalog search and notice the 'Show local items only' button above the "Location" column. 3. Click it to show information ( in that column ) that is only related to the branch you are currently logged in at. 4. In the same result set have some items that are checked out, withdrawn, lost, damaged, and notforlaon. 5. Play more with the search results and ensure everything is accurate. Created attachment 179690 [details] [review] Bug 37883: Add FilterSearchResultsByLoggedInBranch system preference Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Created attachment 179691 [details] [review] Bug Bug 37883: Adjust template for new system preference Created attachment 179692 [details] [review] Bug 37883: Use localStorage to remember user selection Created attachment 179693 [details] [review] Bug 37883: A couple minor fixes to results.tt Created attachment 179694 [details] [review] Bug 37883: Fix branchspecific display of unavailable items Created attachment 179920 [details] [review] Bug Bug 37883: Adjust template for new system preference Created attachment 179921 [details] [review] Bug 37883: Add logged in branch available, other, and onloan counts Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Created attachment 179922 [details] [review] Bug 37883: Add ability to filter search results location column by logged in location To test: 1. Apply patch, restart_all, and regenerate CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface ) I also recommend clearing your browser cache. 2. Do a catalog search and notice the 'Show local items only' button above the "Location" column. 3. Click it to show information ( in that column ) that is only related to the branch you are currently logged in at. 4. In the same result set have some items that are checked out, withdrawn, lost, damaged, and notforlaon. 5. Play more with the search results and ensure everything is accurate. Created attachment 179923 [details] [review] Bug 37883: Add FilterSearchResultsByLoggedInBranch system preference Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Created attachment 179924 [details] [review] Bug 37883: Use localStorage to remember user selection Created attachment 179925 [details] [review] Bug 37883: A couple minor fixes to results.tt Created attachment 179926 [details] [review] Bug 37883: Fix branchspecific display of unavailable items Created attachment 179927 [details] [review] Bug 37883: Correct permissions of atomicupdate file |