The term "library" is preferred to "branch" in the staff interface https://wiki.koha-community.org/wiki/Terminology#B Bug 37883 introduced a new system preference with "branch". FilterSearchResultsByLoggedInBranch : Don't/Do add a filter to the location column on staff interface search results to filter items by the logged in user branch.
Created attachment 190417 [details] [review] Bug 41427: Rephrase FilterSearchResultsByLoggedInBranch description This patch rephrases the description of the FilterSearchResultsByLoggedInBranch system preference to make it clear it filters items by the library where the user is currently logged in at. It also changes "branch" to "library" in the system preference description. To test: 1. Apply patch 2. Go to Administration > System preferences 3. Search for FilterSearchResultsByLoggedInBranch 4. Read the description, make sure it makes sense, and that the grammar and spelling are correct
I also find misleading the part "the logged in user branch". I feel like it implies that it will filter the items by the branch of the logged in user. But the feature is to filter items by the branch **where** the user is logged in. Maybe it's just my french-speaking brain misunderstanding the sentence. If possible, I'd like a native english speaker to chime in?
Created attachment 190418 [details] [review] Bug 41427: Rephrase FilterSearchResultsByLoggedInBranch description This patch rephrases the description of the FilterSearchResultsByLoggedInBranch system preference to make it clear it filters items by the library where the user is currently logged in at. It also changes "branch" to "library" in the system preference description. To test: 1. Apply patch 2. Go to Administration > System preferences 3. Search for FilterSearchResultsByLoggedInBranch 4. Read the description, make sure it makes sense, and that the grammar and spelling are correct Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 190445 [details] [review] Bug 41427: Rephrase FilterSearchResultsByLoggedInBranch description This patch rephrases the description of the FilterSearchResultsByLoggedInBranch system preference to make it clear it filters items by the library where the user is currently logged in at. It also changes "branch" to "library" in the system preference description. To test: 1. Apply patch 2. Go to Administration > System preferences 3. Search for FilterSearchResultsByLoggedInBranch 4. Read the description, make sure it makes sense, and that the grammar and spelling are correct Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 190446 [details] [review] Bug 41427: (QA follow-up) Add new line at end of file Signed-off-by: David Nind <david@davidnind.com>
Added a follow-up to add a new line at the end of the file - running qa identified this. However, running prove xt/find-missing-new-lines-at-the-end-of-file.t (see bug 40541) didn't pick up that there was no new line.