Bug 41427 - Terminology: branch should be library in FilterSearchResultsByLoggedInBranch
Summary: Terminology: branch should be library in FilterSearchResultsByLoggedInBranch
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Caroline Cyr La Rose
QA Contact: David Nind
URL:
Keywords:
Depends on: 37883
Blocks:
  Show dependency treegraph
 
Reported: 2025-12-10 19:33 UTC by Caroline Cyr La Rose
Modified: 2025-12-11 21:16 UTC (History)
2 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the terminology and improves the description for the FilterSearchResultsByLoggedInBranch system preference - branch should be library.
Version(s) released in:
Circulation function:


Attachments
Bug 41427: Rephrase FilterSearchResultsByLoggedInBranch description (1.68 KB, patch)
2025-12-10 19:44 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 41427: Rephrase FilterSearchResultsByLoggedInBranch description (1.73 KB, patch)
2025-12-10 20:35 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 41427: Rephrase FilterSearchResultsByLoggedInBranch description (1.78 KB, patch)
2025-12-11 21:13 UTC, David Nind
Details | Diff | Splinter Review
Bug 41427: (QA follow-up) Add new line at end of file (1.07 KB, patch)
2025-12-11 21:13 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2025-12-10 19:33:02 UTC
The term "library" is preferred to "branch" in the staff interface https://wiki.koha-community.org/wiki/Terminology#B

Bug 37883 introduced a new system preference with "branch".

FilterSearchResultsByLoggedInBranch : Don't/Do add a filter to the location column on staff interface search results to filter items by the logged in user branch.
Comment 1 Caroline Cyr La Rose 2025-12-10 19:44:51 UTC
Created attachment 190417 [details] [review]
Bug 41427: Rephrase FilterSearchResultsByLoggedInBranch description

This patch rephrases the description of the
FilterSearchResultsByLoggedInBranch system preference to make it
clear it filters items by the library where the user is currently
logged in at. It also changes "branch" to "library" in the
system preference description.

To test:
1. Apply patch
2. Go to Administration > System preferences
3. Search for FilterSearchResultsByLoggedInBranch
4. Read the description, make sure it makes sense, and that the
   grammar and spelling are correct
Comment 2 Caroline Cyr La Rose 2025-12-10 19:47:19 UTC
I also find misleading the part "the logged in user branch". I feel like it implies that it will filter the items by the branch of the logged in user. But the feature is to filter items by the branch **where** the user is logged in.
Maybe it's just my french-speaking brain misunderstanding the sentence. If possible, I'd like a native english speaker to chime in?
Comment 3 Owen Leonard 2025-12-10 20:35:29 UTC
Created attachment 190418 [details] [review]
Bug 41427: Rephrase FilterSearchResultsByLoggedInBranch description

This patch rephrases the description of the
FilterSearchResultsByLoggedInBranch system preference to make it
clear it filters items by the library where the user is currently
logged in at. It also changes "branch" to "library" in the
system preference description.

To test:
1. Apply patch
2. Go to Administration > System preferences
3. Search for FilterSearchResultsByLoggedInBranch
4. Read the description, make sure it makes sense, and that the
   grammar and spelling are correct

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 David Nind 2025-12-11 21:13:03 UTC
Created attachment 190445 [details] [review]
Bug 41427: Rephrase FilterSearchResultsByLoggedInBranch description

This patch rephrases the description of the
FilterSearchResultsByLoggedInBranch system preference to make it
clear it filters items by the library where the user is currently
logged in at. It also changes "branch" to "library" in the
system preference description.

To test:
1. Apply patch
2. Go to Administration > System preferences
3. Search for FilterSearchResultsByLoggedInBranch
4. Read the description, make sure it makes sense, and that the
   grammar and spelling are correct

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2025-12-11 21:13:06 UTC
Created attachment 190446 [details] [review]
Bug 41427: (QA follow-up) Add new line at end of file

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 David Nind 2025-12-11 21:16:04 UTC
Added a follow-up to add a new line at the end of the file - running qa identified this.

However, running prove xt/find-missing-new-lines-at-the-end-of-file.t (see bug 40541) didn't pick up that there was no new line.