Bug 37916

Summary: Plugin search and install regression
Product: Koha Reporter: Martin Renvoize (ashimema) <martin.renvoize>
Component: Staff interfaceAssignee: Martin Renvoize (ashimema) <martin.renvoize>
Status: RESOLVED FIXED QA Contact: Paul Derscheid <paul.derscheid>
Severity: major    
Priority: P5 - low CC: caroline.cyr-la-rose, fridolin.somers, gmcharlt, hammat.wele, jesse, liz, lucas, nick, paul.derscheid
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30897
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.06
Circulation function:
Bug Depends on: 36192    
Bug Blocks:    
Attachments: Bug 37916: Convert plugin install button to form
Bug 37916: Convert plugin install button to form
Bug 37916: Convert plugin install button to form
Bug 36154: Showing LocalCoverImages and CustomCoverImages in the list page in staff interface
Bug 36154: Display images coming from plugin
Bug 36154: Make shelfbrowser.tt to be able to use images coming from plugins

Description Martin Renvoize (ashimema) 2024-09-13 12:58:36 UTC
The CSRF work broke installing plugins from github/gitlab search results.
Comment 1 Martin Renvoize (ashimema) 2024-09-13 13:00:04 UTC
Created attachment 171457 [details] [review]
Bug 37916: Convert plugin install button to form

This patch takes the usual approach of converting linked buttons to form
with the csrf token included.
Comment 2 Phil Ringnalda 2024-09-13 13:38:10 UTC
*** Bug 37909 has been marked as a duplicate of this bug. ***
Comment 3 Jesse Maseto 2024-09-13 14:09:58 UTC
Created attachment 171462 [details] [review]
Bug 37916: Convert plugin install button to form

This patch takes the usual approach of converting linked buttons to form
with the csrf token included.

Signed-off-by: JesseM <jesse@bywatersolutions.com>
Comment 4 Jesse Maseto 2024-09-13 14:13:22 UTC
Thank you Martin. This fixes the issue.
Comment 5 Paul Derscheid 2024-09-13 14:50:11 UTC
Created attachment 171470 [details] [review]
Bug 37916: Convert plugin install button to form

This patch takes the usual approach of converting linked buttons to form
with the csrf token included.

Signed-off-by: JesseM <jesse@bywatersolutions.com>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 6 Paul Derscheid 2024-09-13 14:50:58 UTC
Easy QA, thanks for fixing this :)
Comment 7 Katrin Fischer 2024-09-16 08:54:22 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 8 Hammat wele 2024-10-28 20:41:23 UTC Comment hidden (obsolete)
Comment 9 Hammat wele 2024-10-28 20:41:26 UTC Comment hidden (obsolete)
Comment 10 Hammat wele 2024-10-28 20:41:31 UTC Comment hidden (obsolete)
Comment 11 Lucas Gass (lukeg) 2024-11-18 16:13:20 UTC
Backported to 24.05.x for upcoming 24.05.06
Comment 12 Fridolin Somers 2024-12-02 09:29:43 UTC
Not for 23.11.x
Comment 13 Caroline Cyr La Rose 2025-04-18 19:28:49 UTC
Internal architecture, nothing to add/edit in the manual.