Bug 37916 - Plugin search and install regression
Summary: Plugin search and install regression
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Martin Renvoize (ashimema)
QA Contact: Paul Derscheid
URL:
Keywords:
: 37909 (view as bug list)
Depends on: 36192
Blocks:
  Show dependency tree / graph
 
Reported: 2024-09-13 12:58 UTC by Martin Renvoize (ashimema)
Modified: 2024-11-18 16:13 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.06
Circulation function:

Attachments
Bug 37916: Convert plugin install button to form (2.32 KB, patch)
2024-09-13 13:00 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Bug 37916: Convert plugin install button to form (2.37 KB, patch)
2024-09-13 14:09 UTC, Jesse Maseto 		Details | Diff | Splinter Review
Bug 37916: Convert plugin install button to form (2.43 KB, patch)
2024-09-13 14:50 UTC, Paul Derscheid 		Details | Diff | Splinter Review
Bug 36154: Showing LocalCoverImages and CustomCoverImages in the list page in staff interface (5.42 KB, patch)
2024-10-28 20:41 UTC, Hammat wele 		Details | Diff | Splinter Review
Bug 36154: Display images coming from plugin (12.01 KB, patch)
2024-10-28 20:41 UTC, Hammat wele 		Details | Diff | Splinter Review
Bug 36154: Make shelfbrowser.tt to be able to use images coming from plugins (943 bytes, patch)
2024-10-28 20:41 UTC, Hammat wele 		Details | Diff | Splinter Review
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2024-09-13 12:58:36 UTC 
The CSRF work broke installing plugins from github/gitlab search results.
Comment 1 Martin Renvoize (ashimema) 2024-09-13 13:00:04 UTC 
Created attachment 171457 [details] [review]
Bug 37916: Convert plugin install button to form

This patch takes the usual approach of converting linked buttons to form
with the csrf token included.
Comment 2 Phil Ringnalda 2024-09-13 13:38:10 UTC 
*** Bug 37909 has been marked as a duplicate of this bug. ***
Comment 3 Jesse Maseto 2024-09-13 14:09:58 UTC 
Created attachment 171462 [details] [review]
Bug 37916: Convert plugin install button to form

This patch takes the usual approach of converting linked buttons to form
with the csrf token included.

Signed-off-by: JesseM <jesse@bywatersolutions.com>
Comment 4 Jesse Maseto 2024-09-13 14:13:22 UTC 
Thank you Martin. This fixes the issue.
Comment 5 Paul Derscheid 2024-09-13 14:50:11 UTC 
Created attachment 171470 [details] [review]
Bug 37916: Convert plugin install button to form

This patch takes the usual approach of converting linked buttons to form
with the csrf token included.

Signed-off-by: JesseM <jesse@bywatersolutions.com>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 6 Paul Derscheid 2024-09-13 14:50:58 UTC 
Easy QA, thanks for fixing this :)
Comment 7 Katrin Fischer 2024-09-16 08:54:22 UTC 
Pushed for 24.11!

Well done everyone, thank you!
Comment 8 Hammat wele 2024-10-28 20:41:23 UTC Comment hidden (obsolete)
Comment 9 Hammat wele 2024-10-28 20:41:26 UTC Comment hidden (obsolete)
Comment 10 Hammat wele 2024-10-28 20:41:31 UTC Comment hidden (obsolete)
Comment 11 Lucas Gass (lukeg) 2024-11-18 16:13:20 UTC 
Backported to 24.05.x for upcoming 24.05.06