| Summary: | Incorrect handling of DisplayLibraryFacets in previous database update 23.12.000.36 | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Searching - Elasticsearch | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | Needs documenting --- | QA Contact: | Nick Clemens (kidclamp) <nick> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, lucas, martin.renvoize, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37446 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.11.00,24.05.05
|
|
| Circulation function: | |||
| Bug Depends on: | 35138 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 37953: (bug 35138 follow-up) Fix DisplayLibraryFacets - facet order
Bug 37953: (bug 35138 follow-up) Fix DisplayLibraryFacets - facet order |
||
|
Description
Jonathan Druart
2024-09-18 08:46:39 UTC
Created attachment 171656 [details] [review] Bug 37953: (bug 35138 follow-up) Fix DisplayLibraryFacets - facet order Before bug 35138: DisplayLibraryFacets had priority over the settings in the mappings page. If you had DisplayLibraryFacets set to "holding library" (only) then only the holding library facet was displayed. On 231200036 we were not adjusting the facet order/appearance, but the label, which was wrong. The label must be adjusted for both facets and the order depending on DisplayLibraryFacets. Note that bug 37446 is adding a new db rev to adjust the label for installations that have been updated already. Test plan: 0. checkout c120975b783 (the commit right before 35138 has been pushed) 1. reset_all 2. holding library is set in DisplayLibraryFacets by default 3. checkout main (so without this patch) 4. updatedatabase => ES search result display both facets 5. Repeat 0,1,2 and checkout main + this patch, updatedatabase => ES search result display only the holding library facet Feel free to try with another value in DisplayLibraryFacets Created attachment 171716 [details] [review] Bug 37953: (bug 35138 follow-up) Fix DisplayLibraryFacets - facet order Before bug 35138: DisplayLibraryFacets had priority over the settings in the mappings page. If you had DisplayLibraryFacets set to "holding library" (only) then only the holding library facet was displayed. On 231200036 we were not adjusting the facet order/appearance, but the label, which was wrong. The label must be adjusted for both facets and the order depending on DisplayLibraryFacets. Note that bug 37446 is adding a new db rev to adjust the label for installations that have been updated already. Test plan: 0. checkout c120975b783 (the commit right before 35138 has been pushed) 1. reset_all 2. holding library is set in DisplayLibraryFacets by default 3. checkout main (so without this patch) 4. updatedatabase => ES search result display both facets 5. Repeat 0,1,2 and checkout main + this patch, updatedatabase => ES search result display only the holding library facet Feel free to try with another value in DisplayLibraryFacets Signed-off-by: Nick Clemens <nick@bywatersolutions.com> I cheated and tested with:
perl -e 'use C4::Installer; my $db= C4::Installer::run_db_rev( "installer/data/mysql/db_revs/231200036.pl" ); warn Data::Dumper::Dumper($db->{output})'
I added both homelibrary and holdinglibrary facets back in after each test. Tested with all settings of DisplayLibraryFacets
For libraries who have already upgraded, they will get both facets, but this will prevent issues for libraries who have not yet upgraded.
Small patch, moving to PQA for RM/RMaint testing
Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.05 |