After upgrading to 24.05, the default Elasticsearch-Koha installation has facets for "Holding libraries" and "homelibrary" (see screenshot). Bug 35138 introduced a search_field atomicupdate that changed holdingbranch and homebranch labels based on DisplayLibraryFacets system preference the following way: "holdinglibrary" => "Holding libraries" "homelibrary" => "Home libraries" If DisplayLibraryFacets was set to "both", both labels would be updated. If not, only one of them is changed. DisplayLibraryFacets defaults to "holding" meaning a default Koha setup would only update "Holding libraries" and leave "homelibrary" as it is. https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165813&action=diff#a/installer/data/mysql/atomicupdate/bug_35138.pl_sec1 This creates an unfriendly facet label "homelibrary".
Created attachment 169451 [details] Unfriendly facet label "homelibrary"
I'm trying to understand why the atomicupdate is updating either both of the labels or just one of them, based on DisplayLibraryFacets setting? What is the case where the other label should be left unchanged?
I don't know enough about what is happening (labels for the OPAC were fixed in bug 36750, but your screenshot looks like it is from the staff interface). My understanding is that DisplayLibraryFacets is Zebra only now, so not sure why it would affect Elasticsearch, even if there was a database update for it. In current main using koha-testing-docker and ES8, both of the labels display correctly for me.
Created attachment 170855 [details] [review] Bug 37446: Fix search facets for holding and home libraries This bug ensures that the facet labels for holdingbranch and homebranch are updated, regardless of how the DisplayLibraryFacets system preference is set. To test: 1. Check out an earlier version of Koha, for example `git checkout v23.11.08-1` 2. Spin up your development environment with elasticsearch, for example `ktd --es7 up` 3. Once it's ready, go to the staff interface and search for the DisplayLibraryFacets system preference in Koha administration. Set to 'holding library' if not already. 4. Do a catalogue search, notice the facets on the side. "Holding libraries" should show as normal. There should be no facet for home libraries. 5. In your terminal, check out 24.05.x, for example `git checkout v24.05.03` 6. Run database updates to upgrade Koha, for example `sudo koha-upgrade-schema kohadev`, and restart services `restart_all` 7. Repeat step 4. Notice the error in the facets "homelibrary" 8. Apply patch from Bug 37446 9. Repeat step 6 10. Repeat step 4. This time the facet should read "Home libraries" Sponsored-by: Toi Ohomai Institute of Technology
Created attachment 171238 [details] [review] Bug 37446: Fix search facets for holding and home libraries This bug ensures that the facet labels for holdingbranch and homebranch are updated, regardless of how the DisplayLibraryFacets system preference is set. To test: 1. Check out an earlier version of Koha, for example `git checkout v23.11.08-1` 2. Spin up your development environment with elasticsearch, for example `ktd --es7 up` 3. Once it's ready, go to the staff interface and search for the DisplayLibraryFacets system preference in Koha administration. Set to 'holding library' if not already. 4. Do a catalogue search, notice the facets on the side. "Holding libraries" should show as normal. There should be no facet for home libraries. 5. In your terminal, check out 24.05.x, for example `git checkout v24.05.03` 6. Run database updates to upgrade Koha, for example `sudo koha-upgrade-schema kohadev`, and restart services `restart_all` 7. Repeat step 4. Notice the error in the facets "homelibrary" 8. Apply patch from Bug 37446 9. Repeat step 6 10. Repeat step 4. This time the facet should read "Home libraries" Sponsored-by: Toi Ohomai Institute of Technology Signed-off-by: David Nind <david@davidnind.com>
Yes there is something wrong. The label should be adjusted for both, but we needed to take into account DisplayLibraryFacets to set facet_order to NUL if we didn't want to display it. Is that correct?