Bug 37954

Created attachment 171659 [details] [review]
Bug 37954: Fix barcode column name

Patch https://github.com/Koha-Community/Koha/commit/6cbbfa2 changed holdings_barcode to holdings_barcodes

I believe this caused the configuration from the table to no longer work (barcodes!=barcode)

Test plan:
1) Access any bibllio:
<staff_url>/cgi-bin/koha/catalogue/detail.pl?biblionumber=76
2) On the top right of the table, click 'Configure'
3) Expand 'Catalog', search for 'holdings_barcode'. Tick 'is hidden by default'. Save.
4) Visit the biblio again, notice the column is still showing.
5) Apply patch. Restart all + flush_memcached. Repeat.
6) Bonus: On the table, click 'Show filters'. Make sure barcode filtering still works.

Created attachment 171662 [details] [review]
Bug 37954: Fix barcode column name

Patch https://github.com/Koha-Community/Koha/commit/6cbbfa2 changed
holdings_barcode to holdings_barcodes

I believe this caused the configuration from the table to no longer
work (barcodes!=barcode)

Test plan:
1) Access any bibllio:
   <staff_url>/cgi-bin/koha/catalogue/detail.pl?biblionumber=76
2) On the top right of the table, click 'Configure'
3) Expand 'Catalog', search for 'holdings_barcode'. Tick 'is hidden by
   default'. Save.
4) Visit the biblio again, notice the column is still showing.
5) Apply patch. Restart all + flush_memcached. Repeat.
6) Bonus: On the table, click 'Show filters'. Make sure barcode
   filtering still works.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Created attachment 171698 [details] [review]
Bug 37954: Fix barcode column name

Patch https://github.com/Koha-Community/Koha/commit/6cbbfa2 changed
holdings_barcode to holdings_barcodes

I believe this caused the configuration from the table to no longer
work (barcodes!=barcode)

Test plan:
1) Access any bibllio:
   <staff_url>/cgi-bin/koha/catalogue/detail.pl?biblionumber=76
2) On the top right of the table, click 'Configure'
3) Expand 'Catalog', search for 'holdings_barcode'. Tick 'is hidden by
   default'. Save.
4) Visit the biblio again, notice the column is still showing.
5) Apply patch. Restart all + flush_memcached. Repeat.
6) Bonus: On the table, click 'Show filters'. Make sure barcode
   filtering still works.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: David Nind <david@davidnind.com>

I've added my sign off - maybe Owen could do the QA.

Created attachment 171713 [details] [review]
Bug 37954: Fix barcode column name

Patch https://github.com/Koha-Community/Koha/commit/6cbbfa2 changed
holdings_barcode to holdings_barcodes

I believe this caused the configuration from the table to no longer
work (barcodes!=barcode)

Test plan:
1) Access any bibllio:
   <staff_url>/cgi-bin/koha/catalogue/detail.pl?biblionumber=76
2) On the top right of the table, click 'Configure'
3) Expand 'Catalog', search for 'holdings_barcode'. Tick 'is hidden by
   default'. Save.
4) Visit the biblio again, notice the column is still showing.
5) Apply patch. Restart all + flush_memcached. Repeat.
6) Bonus: On the table, click 'Show filters'. Make sure barcode
   filtering still works.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Created attachment 171714 [details] [review]
Bug 37954: Atomic update

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

I think we need to address existing data here - we shouldn't make the users need to update again.

I suspect the changes happened in bug 33568 as bug 32447 was fixing the issue of barcode filters not working.

Leaving as SO to get QA on the update

Created attachment 172561 [details] [review]
Bug 37954: Fix barcode column name

Patch https://github.com/Koha-Community/Koha/commit/6cbbfa2 changed
holdings_barcode to holdings_barcodes

I believe this caused the configuration from the table to no longer
work (barcodes!=barcode)

Test plan:
1) Access any bibllio:
   <staff_url>/cgi-bin/koha/catalogue/detail.pl?biblionumber=76
2) On the top right of the table, click 'Configure'
3) Expand 'Catalog', search for 'holdings_barcode'. Tick 'is hidden by
   default'. Save.
4) Visit the biblio again, notice the column is still showing.
5) Apply patch. Restart all + flush_memcached. Repeat.
6) Bonus: On the table, click 'Show filters'. Make sure barcode
   filtering still works.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Created attachment 172562 [details] [review]
Bug 37954: Atomic update

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Update tested and I'm happy that it achieves the desired effects.

Adding PQA

Adding 23.11 version of the atomic update here if RMaint decides to backport.

Created attachment 172564 [details] [review]
[23.11] Bug 37954: Atomic update

(In reply to Pedro Amorim from comment #12)
> Adding 23.11 version of the atomic update here if RMaint decides to backport.

What is the difference?

(In reply to Katrin Fischer from comment #14)
> (In reply to Pedro Amorim from comment #12)
> > Adding 23.11 version of the atomic update here if RMaint decides to backport.
> 
> What is the difference?

use Koha::Installer::Output qw(say_warning say_failure say_success say_info);

Addded in bug 35681, pushed to 24.05.

(In reply to Pedro Amorim from comment #15)
> (In reply to Katrin Fischer from comment #14)
> > (In reply to Pedro Amorim from comment #12)
> > > Adding 23.11 version of the atomic update here if RMaint decides to backport.
> > 
> > What is the difference?
> 
> use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
> 
> Addded in bug 35681, pushed to 24.05.

Thanks!

Pushed for 24.11!

Well done everyone, thank you!

Backported to 24.05.x for upcoming 24.05.06