Bug 37954 - Unable to hide barcode column in holdings table
Summary: Unable to hide barcode column in holdings table
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Pedro Amorim
QA Contact: Nick Clemens (kidclamp)
URL:
Keywords:
Depends on: 32447
Blocks:
  Show dependency treegraph
 
Reported: 2024-09-18 10:18 UTC by Pedro Amorim
Modified: 2024-10-11 10:27 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes hiding the barcode column on the staff interface for a record's holdings table. You can now turn on or off hiding the barcode by default, and select the display of the barcode column using the 'Columns' setting.
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 37954: Fix barcode column name (1.36 KB, patch)
2024-09-18 10:23 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 37954: Fix barcode column name (1.42 KB, patch)
2024-09-18 13:17 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 37954: Fix barcode column name (1.46 KB, patch)
2024-09-18 21:37 UTC, David Nind
Details | Diff | Splinter Review
Bug 37954: Fix barcode column name (1.52 KB, patch)
2024-09-19 11:41 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 37954: Atomic update (2.49 KB, patch)
2024-09-19 11:41 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 37954: Fix barcode column name (1.58 KB, patch)
2024-10-09 08:35 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 37954: Atomic update (2.55 KB, patch)
2024-10-09 08:35 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
[23.11] Bug 37954: Atomc update (1.56 KB, patch)
2024-10-09 08:48 UTC, Pedro Amorim
Details | Diff | Splinter Review
[23.11] Bug 37954: Atomic update (2.33 KB, patch)
2024-10-09 08:50 UTC, Pedro Amorim
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2024-09-18 10:18:41 UTC

    
Comment 1 Pedro Amorim 2024-09-18 10:23:05 UTC
Created attachment 171659 [details] [review]
Bug 37954: Fix barcode column name

Patch https://github.com/Koha-Community/Koha/commit/6cbbfa2 changed holdings_barcode to holdings_barcodes

I believe this caused the configuration from the table to no longer work (barcodes!=barcode)

Test plan:
1) Access any bibllio:
<staff_url>/cgi-bin/koha/catalogue/detail.pl?biblionumber=76
2) On the top right of the table, click 'Configure'
3) Expand 'Catalog', search for 'holdings_barcode'. Tick 'is hidden by default'. Save.
4) Visit the biblio again, notice the column is still showing.
5) Apply patch. Restart all + flush_memcached. Repeat.
6) Bonus: On the table, click 'Show filters'. Make sure barcode filtering still works.
Comment 2 Owen Leonard 2024-09-18 13:17:25 UTC
Created attachment 171662 [details] [review]
Bug 37954: Fix barcode column name

Patch https://github.com/Koha-Community/Koha/commit/6cbbfa2 changed
holdings_barcode to holdings_barcodes

I believe this caused the configuration from the table to no longer
work (barcodes!=barcode)

Test plan:
1) Access any bibllio:
   <staff_url>/cgi-bin/koha/catalogue/detail.pl?biblionumber=76
2) On the top right of the table, click 'Configure'
3) Expand 'Catalog', search for 'holdings_barcode'. Tick 'is hidden by
   default'. Save.
4) Visit the biblio again, notice the column is still showing.
5) Apply patch. Restart all + flush_memcached. Repeat.
6) Bonus: On the table, click 'Show filters'. Make sure barcode
   filtering still works.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 David Nind 2024-09-18 21:37:07 UTC
Created attachment 171698 [details] [review]
Bug 37954: Fix barcode column name

Patch https://github.com/Koha-Community/Koha/commit/6cbbfa2 changed
holdings_barcode to holdings_barcodes

I believe this caused the configuration from the table to no longer
work (barcodes!=barcode)

Test plan:
1) Access any bibllio:
   <staff_url>/cgi-bin/koha/catalogue/detail.pl?biblionumber=76
2) On the top right of the table, click 'Configure'
3) Expand 'Catalog', search for 'holdings_barcode'. Tick 'is hidden by
   default'. Save.
4) Visit the biblio again, notice the column is still showing.
5) Apply patch. Restart all + flush_memcached. Repeat.
6) Bonus: On the table, click 'Show filters'. Make sure barcode
   filtering still works.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2024-09-18 21:37:41 UTC
I've added my sign off - maybe Owen could do the QA.
Comment 5 Nick Clemens (kidclamp) 2024-09-19 11:41:11 UTC
Created attachment 171713 [details] [review]
Bug 37954: Fix barcode column name

Patch https://github.com/Koha-Community/Koha/commit/6cbbfa2 changed
holdings_barcode to holdings_barcodes

I believe this caused the configuration from the table to no longer
work (barcodes!=barcode)

Test plan:
1) Access any bibllio:
   <staff_url>/cgi-bin/koha/catalogue/detail.pl?biblionumber=76
2) On the top right of the table, click 'Configure'
3) Expand 'Catalog', search for 'holdings_barcode'. Tick 'is hidden by
   default'. Save.
4) Visit the biblio again, notice the column is still showing.
5) Apply patch. Restart all + flush_memcached. Repeat.
6) Bonus: On the table, click 'Show filters'. Make sure barcode
   filtering still works.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 6 Nick Clemens (kidclamp) 2024-09-19 11:41:14 UTC
Created attachment 171714 [details] [review]
Bug 37954: Atomic update

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 7 Nick Clemens (kidclamp) 2024-09-19 11:43:05 UTC
I think we need to address existing data here - we shouldn't make the users need to update again.

I suspect the changes happened in bug 33568 as bug 32447 was fixing the issue of barcode filters not working.

Leaving as SO to get QA on the update
Comment 8 Martin Renvoize (ashimema) 2024-10-09 08:35:45 UTC
Created attachment 172561 [details] [review]
Bug 37954: Fix barcode column name

Patch https://github.com/Koha-Community/Koha/commit/6cbbfa2 changed
holdings_barcode to holdings_barcodes

I believe this caused the configuration from the table to no longer
work (barcodes!=barcode)

Test plan:
1) Access any bibllio:
   <staff_url>/cgi-bin/koha/catalogue/detail.pl?biblionumber=76
2) On the top right of the table, click 'Configure'
3) Expand 'Catalog', search for 'holdings_barcode'. Tick 'is hidden by
   default'. Save.
4) Visit the biblio again, notice the column is still showing.
5) Apply patch. Restart all + flush_memcached. Repeat.
6) Bonus: On the table, click 'Show filters'. Make sure barcode
   filtering still works.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 9 Martin Renvoize (ashimema) 2024-10-09 08:35:48 UTC
Created attachment 172562 [details] [review]
Bug 37954: Atomic update

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 10 Martin Renvoize (ashimema) 2024-10-09 08:36:16 UTC
Update tested and I'm happy that it achieves the desired effects.

Adding PQA
Comment 11 Pedro Amorim 2024-10-09 08:48:18 UTC Comment hidden (obsolete)
Comment 12 Pedro Amorim 2024-10-09 08:48:54 UTC
Adding 23.11 version of the atomic update here if RMaint decides to backport.
Comment 13 Pedro Amorim 2024-10-09 08:50:04 UTC
Created attachment 172564 [details] [review]
[23.11] Bug 37954: Atomic update
Comment 14 Katrin Fischer 2024-10-11 09:17:58 UTC
(In reply to Pedro Amorim from comment #12)
> Adding 23.11 version of the atomic update here if RMaint decides to backport.

What is the difference?
Comment 15 Pedro Amorim 2024-10-11 09:50:33 UTC
(In reply to Katrin Fischer from comment #14)
> (In reply to Pedro Amorim from comment #12)
> > Adding 23.11 version of the atomic update here if RMaint decides to backport.
> 
> What is the difference?

use Koha::Installer::Output qw(say_warning say_failure say_success say_info);

Addded in bug 35681, pushed to 24.05.
Comment 16 Katrin Fischer 2024-10-11 09:51:05 UTC
(In reply to Pedro Amorim from comment #15)
> (In reply to Katrin Fischer from comment #14)
> > (In reply to Pedro Amorim from comment #12)
> > > Adding 23.11 version of the atomic update here if RMaint decides to backport.
> > 
> > What is the difference?
> 
> use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
> 
> Addded in bug 35681, pushed to 24.05.

Thanks!
Comment 17 Katrin Fischer 2024-10-11 10:27:46 UTC
Pushed for 24.11!

Well done everyone, thank you!