Summary: | Clicking table's 'configure' button no longer opens column settings page properly | ||
---|---|---|---|
Product: | Koha | Reporter: | Pedro Amorim <pedro.amorim> |
Component: | Staff interface | Assignee: | Owen Leonard <oleonard> |
Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, jonathan.druart, katrin.fischer, lucas, martin.renvoize, oleonard, paul.derscheid |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.11.00
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 38069 | ||
Attachments: |
Bug 37955: Fix table's 'configure' button to open correct column settings
Bug 37955: Fix table's 'configure' button to open correct column settings Bug 37955: Fix table's 'configure' button to open correct column settings |
Description
Pedro Amorim
2024-09-18 10:36:04 UTC
Created attachment 171661 [details] [review] Bug 37955: Fix table's 'configure' button to open correct column settings This patch updates markup and JS code on the table settings page so that clicking a table's "configure" button will open the right panel and scroll you to the correct table. The patch also overrides Bootstrap's default table caption positioning so that captions are above the table instead of below them. Unfortunately this property isn't in Bootstrap's _variables. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface). - Find a table in the staff interface which has a "Configure" button, e.g. Administration -> Libraries. - Click the "Configure" button. - When you arrive at the table settings page the correct panel should be expanded (in this example, Administration), and the page should scroll to the correct table (in this example, libraries). - The table caption ("Table id: libraries") should appear before the table instead of after. Created attachment 171684 [details] [review] Bug 37955: Fix table's 'configure' button to open correct column settings This patch updates markup and JS code on the table settings page so that clicking a table's "configure" button will open the right panel and scroll you to the correct table. The patch also overrides Bootstrap's default table caption positioning so that captions are above the table instead of below them. Unfortunately this property isn't in Bootstrap's _variables. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface). - Find a table in the staff interface which has a "Configure" button, e.g. Administration -> Libraries. - Click the "Configure" button. - When you arrive at the table settings page the correct panel should be expanded (in this example, Administration), and the page should scroll to the correct table (in this example, libraries). - The table caption ("Table id: libraries") should appear before the table instead of after. Signed-off-by: David Nind <david@davidnind.com> Created attachment 171710 [details] [review] Bug 37955: Fix table's 'configure' button to open correct column settings This patch updates markup and JS code on the table settings page so that clicking a table's "configure" button will open the right panel and scroll you to the correct table. The patch also overrides Bootstrap's default table caption positioning so that captions are above the table instead of below them. Unfortunately this property isn't in Bootstrap's _variables. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface). - Find a table in the staff interface which has a "Configure" button, e.g. Administration -> Libraries. - Click the "Configure" button. - When you arrive at the table settings page the correct panel should be expanded (in this example, Administration), and the page should scroll to the correct table (in this example, libraries). - The table caption ("Table id: libraries") should appear before the table instead of after. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant table_id was used later, the form cannot be saved, see bug 38069 Missing 24.05.x deps |