|
Description
Paul Derscheid
2024-09-20 13:35:58 UTC
Created attachment 171831 [details] [review] Bug 37972: Allow selection of tab in patron's summary table by query param To test: 1) Apply the patch 2) Place a hold on any biblio with the 'koha' patron for example 3) Authenticate in the OPAC with the patron you picked in step 1 4) Open opac-user.pl with the query param 'tab': /cgi-bin/koha/opac-user.pl?tab=opac-user-holds 5) Note that the holds tab in the patron's user summary is automatically selected 6) Sign-off I'm totally open to renaming the query param, so if you have a suggestion that's more consistent with the rest of koha, I'm all ears. Get this error when attempting to access patron's account (maybe a common is required for the code change: tab = > $query->param('tab'); ):
Could not compile /kohadevbox/koha/opac/opac-user.pl: syntax error at /kohadevbox/koha/opac/opac-user.pl line 409, near ");"
syntax error at /kohadevbox/koha/opac/opac-user.pl line 416, near ")"
BEGIN not safe after errors--compilation aborted at /kohadevbox/koha/opac/opac-user.pl line 453.
at /usr/share/perl5/CGI/Compile.pm line 144
in CGI::Compile::compile at /usr/share/perl5/CGI/Compile.pm line 144
141: my $code = $self->_eval($eval);
142: my $exception = $@;
143:
144: die "Could not compile $script: $exception" if $exception;
145:
Ah, thanks David. It's the old ';' instead of ','. Created attachment 171874 [details] [review] Bug 37972: (follow-up) Correct syntax error in opac/opac-user.pl Created attachment 171885 [details] [review] Bug 37972: Allow selection of tab in patron's summary table by query param To test: 1) Apply the patch 2) Place a hold on any biblio with the 'koha' patron for example 3) Authenticate in the OPAC with the patron you picked in step 1 4) Open opac-user.pl with the query param 'tab': /cgi-bin/koha/opac-user.pl?tab=opac-user-holds 5) Note that the holds tab in the patron's user summary is automatically selected 6) Sign-off I'm totally open to renaming the query param, so if you have a suggestion that's more consistent with the rest of koha, I'm all ears. Signed-off-by: David Nind <david@davidnind.com> Created attachment 171886 [details] [review] Bug 37972: (follow-up) Correct syntax error in opac/opac-user.pl Signed-off-by: David Nind <david@davidnind.com> Thanks for fixing! I think I would prefer opac-patron-xxx, however opac-user-xxx exists already so we probably shouldn't change it. Created attachment 171900 [details] [review] Bug 37972: Allow selection of tab in patron's summary table by query param To test: 1) Apply the patch 2) Place a hold on any biblio with the 'koha' patron for example 3) Authenticate in the OPAC with the patron you picked in step 1 4) Open opac-user.pl with the query param 'tab': /cgi-bin/koha/opac-user.pl?tab=opac-user-holds 5) Note that the holds tab in the patron's user summary is automatically selected 6) Sign-off I'm totally open to renaming the query param, so if you have a suggestion that's more consistent with the rest of koha, I'm all ears. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 171901 [details] [review] Bug 37972: (follow-up) Correct syntax error in opac/opac-user.pl Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 171902 [details] [review] Bug 37972: (QA follow-up) add missing filter Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Pushed for 24.11! Well done everyone, thank you! Not going to block this, but I feel we have solved this in other spots already. Adding Owen for some additional insight. |