Bug 41558 - Broken links to tab on opac-user
Summary: Broken links to tab on opac-user
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 33895 37972
Blocks: 41582
  Show dependency treegraph
 
Reported: 2026-01-09 11:12 UTC by Jonathan Druart
Modified: 2026-01-09 22:50 UTC (History)
1 user (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 41558: Fix and standardize links to tab on opac-user (12.67 KB, patch)
2026-01-09 11:15 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 41558: Fix and standardize links to tab on opac-user (12.72 KB, patch)
2026-01-09 11:34 UTC, Paul Derscheid
Details | Diff | Splinter Review
Bug 41558: Fix and standardize links to tab on opac-user (12.75 KB, patch)
2026-01-09 22:44 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2026-01-09 11:12:02 UTC
We have different implemented solution to select a tab on opac-user:
* a "tab" variable (from bug 37972), it's never used
* several variables passed from the controller to the template, depending on the tab to select (it works and is used)
* use of anchors (it does not work and is used)

We should fix and standardize it.

I've linked to several reports that seem to conflict with each others.
Comment 1 Jonathan Druart 2026-01-09 11:15:00 UTC
Created attachment 191048 [details] [review]
Bug 41558: Fix and standardize links to tab on opac-user

We have different implemented solution to select a tab on opac-user:
* a "tab" variable (from bug 37972), it's never used
* several variables passed from the controller to the template, depending on the tab to select (it works and is used)
* use of anchors (it does not work and is used)

We should fix and standardize it.

I've linked to several reports that seem to conflict with each others.

This patch suggests to have a "tab" variable

Test plan:
Confirm that the different links to tab to opac-user are not using a
query parameter to pass the tab to select, e.g. from the opac-main page.
Comment 2 Paul Derscheid 2026-01-09 11:34:11 UTC
Created attachment 191049 [details] [review]
Bug 41558: Fix and standardize links to tab on opac-user

We have different implemented solution to select a tab on opac-user:
* a "tab" variable (from bug 37972), it's never used
* several variables passed from the controller to the template, depending on the tab to select (it works and is used)
* use of anchors (it does not work and is used)

We should fix and standardize it.

I've linked to several reports that seem to conflict with each others.

This patch suggests to have a "tab" variable

Test plan:
Confirm that the different links to tab to opac-user are not using a
query parameter to pass the tab to select, e.g. from the opac-main page.

Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 3 David Nind 2026-01-09 22:44:51 UTC
Created attachment 191234 [details] [review]
Bug 41558: Fix and standardize links to tab on opac-user

We have different implemented solution to select a tab on opac-user:
* a "tab" variable (from bug 37972), it's never used
* several variables passed from the controller to the template, depending on the tab to select (it works and is used)
* use of anchors (it does not work and is used)

We should fix and standardize it.

I've linked to several reports that seem to conflict with each others.

This patch suggests to have a "tab" variable

Test plan:
Confirm that the different links to tab to opac-user are not using a
query parameter to pass the tab to select, e.g. from the opac-main page.

Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2026-01-09 22:50:02 UTC
I've added my sign-off, in case Paul's can be counted as QA.

Testing notes (using KTD):

1. Tabs are still directly accessible, for example:
   /cgi-bin/koha/opac-user.pl?tab=opac-user-recalls