Summary: | Fix some issues with labels in inventory form | ||
---|---|---|---|
Product: | Koha | Reporter: | Phil Ringnalda <phil> |
Component: | Templates | Assignee: | Phil Ringnalda <phil> |
Status: | Pushed to main --- | QA Contact: | Chris Cormack <chris> |
Severity: | normal | ||
Priority: | P3 | CC: | martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38008 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.11.00
|
|
Circulation function: | |||
Attachments: |
Bug 37977: Fix some issues with labels in Inventory form
Bug 37977: Fix some issues with labels in Inventory form Bug 37977: Fix some issues with labels in Inventory form |
Description
Phil Ringnalda
2024-09-20 21:40:28 UTC
Created attachment 171842 [details] [review] Bug 37977: Fix some issues with labels in Inventory form The inventory form has several issues with labels with a for attribute that doesn't match the id of the input, so the label doesn't actually get linked to anything. Test plan: 1. Without the patch, go to Cataloging - Inventory 2. In the section for "Item location filters" click the label for "Shelving location (items.location) is", which will focus the select menu, then press the down arrow on the keyboard to see that it's focused by opening the select menu. 3. Click in a blank spot to close the select menu, then click the label for "Collection" and press the down arrow key, which will scroll the page since the label didn't focus the menu, and repeat with "Call number classification scheme" which also will scroll the page when you press down arrow. 4. In the section for "Optional filters for inventory list or comparing barcodes" click any of the labels below items.notforloan - clicking a checkbox label should toggle whether the checkbox is checked, but it will not 5. Apply patch, refresh page 6. Repeat steps 3 and 4, but this time you will get the proper behavior, focusing the select menus and toggling the checkboxes Sponsored-by: Chetco Community Public Library Created attachment 171847 [details] [review] Bug 37977: Fix some issues with labels in Inventory form The inventory form has several issues with labels with a for attribute that doesn't match the id of the input, so the label doesn't actually get linked to anything. Test plan: 1. Without the patch, go to Cataloging - Inventory 2. In the section for "Item location filters" click the label for "Shelving location (items.location) is", which will focus the select menu, then press the down arrow on the keyboard to see that it's focused by opening the select menu. 3. Click in a blank spot to close the select menu, then click the label for "Collection" and press the down arrow key, which will scroll the page since the label didn't focus the menu, and repeat with "Call number classification scheme" which also will scroll the page when you press down arrow. 4. In the section for "Optional filters for inventory list or comparing barcodes" click any of the labels below items.notforloan - clicking a checkbox label should toggle whether the checkbox is checked, but it will not 5. Apply patch, refresh page 6. Repeat steps 3 and 4, but this time you will get the proper behavior, focusing the select menus and toggling the checkboxes Sponsored-by: Chetco Community Public Library Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 172932 [details] [review] Bug 37977: Fix some issues with labels in Inventory form The inventory form has several issues with labels with a for attribute that doesn't match the id of the input, so the label doesn't actually get linked to anything. Test plan: 1. Without the patch, go to Cataloging - Inventory 2. In the section for "Item location filters" click the label for "Shelving location (items.location) is", which will focus the select menu, then press the down arrow on the keyboard to see that it's focused by opening the select menu. 3. Click in a blank spot to close the select menu, then click the label for "Collection" and press the down arrow key, which will scroll the page since the label didn't focus the menu, and repeat with "Call number classification scheme" which also will scroll the page when you press down arrow. 4. In the section for "Optional filters for inventory list or comparing barcodes" click any of the labels below items.notforloan - clicking a checkbox label should toggle whether the checkbox is checked, but it will not 5. Apply patch, refresh page 6. Repeat steps 3 and 4, but this time you will get the proper behavior, focusing the select menus and toggling the checkboxes Sponsored-by: Chetco Community Public Library Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Pushed for 24.11! Well done everyone, thank you! |