Bug 38008 - Presentation CSS on label tags makes it hard to use for radio buttons and Flatpickr
Summary: Presentation CSS on label tags makes it hard to use for radio buttons and Fla...
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-25 23:49 UTC by Phil Ringnalda
Modified: 2024-10-02 19:39 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Phil Ringnalda 2024-09-25 23:49:21 UTC
In the case I'm trying to fix, Cataloging - Inventory, there are radio buttons for Home library or Current library, so the way radio buttons work those phrases should be the <label>s, so that clicking them toggles the buttons themselves. But the presentation of the whole page is geared to CSS for label, with only a little of it for .label, which assumes that whenever you have <fieldset class="rows"> ... <label> you will want that label to float: left and text-align: right, etc.

Flatpickr is a somewhat similar problem: the project has decided that people who want to have the id in their dummy <input> which Flatpickr hides and replaces with its input transferred to the Flatpicker input are silly, because you can just wrap a label around the thing it is for, rather than having a sibling label with a for attribute pointing to the id of the input. But because of the floating and text-aligning, etc., of label, if you have <label>Set inventory date to: <input class="flatpickr"/></label> you get a ton of unwanted inherited presentation.