Bug 37980

Summary: Style corrections for installer and onboarding following Bootstrap 5 update
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Staff interfaceAssignee: Owen Leonard <oleonard>
Status: RESOLVED FIXED QA Contact: Martin Renvoize (ashimema) <martin.renvoize>
Severity: normal    
Priority: P5 - low CC: david, gmcharlt, lucas, martin.renvoize, phil
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:
Bug Depends on: 35402    
Bug Blocks: 38379    
Attachments: Bug 37980: Style corrections for installer and onboarding following Bootstrap 5 update
Bug 37980: Style corrections for installer and onboarding following Bootstrap 5 update
Bug 37980: Style corrections for installer and onboarding following Bootstrap 5 update

Description Jonathan Druart 2024-09-23 08:58:46 UTC
Guess it's coming from the Bootstrap5 update: the login screen is not centered.
Comment 1 Owen Leonard 2024-10-08 12:17:56 UTC
Created attachment 172518 [details] [review]
Bug 37980: Style corrections for installer and onboarding following Bootstrap 5 update

This patch makes a couple of CSS updates to the installer and and
onboarding pages:

1. Add more Bootstrap imports to the installer SCSS. I included a
   pared-down selection of components to save file size. I should have
   included more.
2. Add a temporary fix for the fact that the Font Awesome checkbox icons
   aren't working correctly. According to the docs the "empty check box"
   icons should look like a square border, not a solid square. They
   don't, and I've included a temporary fix for it.

To test apply the patch and rebuild the staff interface CSS.

- Drop and recreate the Koha database. Run 'restart_all' if necessary.
- Navigate to the staff interface. You should be presented with the
  installer login. The form should be centered on the page.
- Log in. In the list of steps displayed on the "Choose your language"
  page you should see square icons resembling empty checkboxes (not
  solid black squares).
- Select your language and proceed to the next step. The "Choose your
  language" line should now have a green icon of a checked checkbox.
- Follow the rest of the installer and onboarding steps to confirm that
  there aren't other unreported style issues.
Comment 2 Phil Ringnalda 2024-10-10 22:19:37 UTC
Created attachment 172672 [details] [review]
Bug 37980: Style corrections for installer and onboarding following Bootstrap 5 update

This patch makes a couple of CSS updates to the installer and and
onboarding pages:

1. Add more Bootstrap imports to the installer SCSS. I included a
   pared-down selection of components to save file size. I should have
   included more.
2. Add a temporary fix for the fact that the Font Awesome checkbox icons
   aren't working correctly. According to the docs the "empty check box"
   icons should look like a square border, not a solid square. They
   don't, and I've included a temporary fix for it.

To test apply the patch and rebuild the staff interface CSS.

- Drop and recreate the Koha database. Run 'restart_all' if necessary.
- Navigate to the staff interface. You should be presented with the
  installer login. The form should be centered on the page.
- Log in. In the list of steps displayed on the "Choose your language"
  page you should see square icons resembling empty checkboxes (not
  solid black squares).
- Select your language and proceed to the next step. The "Choose your
  language" line should now have a green icon of a checked checkbox.
- Follow the rest of the installer and onboarding steps to confirm that
  there aren't other unreported style issues.

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 3 Martin Renvoize (ashimema) 2024-10-28 10:56:33 UTC
Created attachment 173509 [details] [review]
Bug 37980: Style corrections for installer and onboarding following Bootstrap 5 update

This patch makes a couple of CSS updates to the installer and and
onboarding pages:

1. Add more Bootstrap imports to the installer SCSS. I included a
   pared-down selection of components to save file size. I should have
   included more.
2. Add a temporary fix for the fact that the Font Awesome checkbox icons
   aren't working correctly. According to the docs the "empty check box"
   icons should look like a square border, not a solid square. They
   don't, and I've included a temporary fix for it.

To test apply the patch and rebuild the staff interface CSS.

- Drop and recreate the Koha database. Run 'restart_all' if necessary.
- Navigate to the staff interface. You should be presented with the
  installer login. The form should be centered on the page.
- Log in. In the list of steps displayed on the "Choose your language"
  page you should see square icons resembling empty checkboxes (not
  solid black squares).
- Select your language and proceed to the next step. The "Choose your
  language" line should now have a green icon of a checked checkbox.
- Follow the rest of the installer and onboarding steps to confirm that
  there aren't other unreported style issues.

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Katrin Fischer 2024-10-29 07:54:19 UTC
Pushed for 24.11!

Well done everyone, thank you!