Bug 38379 - Remove obsolete Bootstrap classes from installer templates
Summary: Remove obsolete Bootstrap classes from installer templates
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Paul Derscheid
URL:
Keywords:
Depends on: 37980
Blocks:
  Show dependency treegraph
 
Reported: 2024-11-06 13:43 UTC by Owen Leonard
Modified: 2024-12-05 22:05 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 38379: Remove obsolete Bootstrap classes from installer templates (7.57 KB, patch)
2024-11-06 13:49 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38379: Remove obsolete Bootstrap classes from installer templates (7.64 KB, patch)
2024-11-06 16:56 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 38379: Remove obsolete Bootstrap classes from installer templates (7.68 KB, patch)
2024-11-07 09:57 UTC, Paul Derscheid
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2024-11-06 13:43:03 UTC
Bug 37980 fixed the layout of the installer and onboarding templates but didn't completely remove all the obsolete grid classes. "col-sm-offset-2" remains in several templates.
Comment 1 Owen Leonard 2024-11-06 13:49:19 UTC
Created attachment 174078 [details] [review]
Bug 38379: Remove obsolete Bootstrap classes from installer templates

This patch makes some minor markup changes to the installer and
onboarding templates so that obsolete Bootstrap grid classes are
removed. The patch also adds another breakpoint to the grid classes to
that the content adjusts well at smaller viewport sizes.

To test, apply the patch and rebuild the staff interface CSS.

- Drop and recreate the Koha database. Run 'restart_all' if necessary.
- Navigate to the staff interface. You should be presented with the
  installer login. The form should be centered on the page.
- Log in and follow the installer and onboarding steps to confirm that
  the layout looks correct on each page.
Comment 2 Lucas Gass (lukeg) 2024-11-06 16:56:31 UTC
Created attachment 174084 [details] [review]
Bug 38379: Remove obsolete Bootstrap classes from installer templates

This patch makes some minor markup changes to the installer and
onboarding templates so that obsolete Bootstrap grid classes are
removed. The patch also adds another breakpoint to the grid classes to
that the content adjusts well at smaller viewport sizes.

To test, apply the patch and rebuild the staff interface CSS.

- Drop and recreate the Koha database. Run 'restart_all' if necessary.
- Navigate to the staff interface. You should be presented with the
  installer login. The form should be centered on the page.
- Log in and follow the installer and onboarding steps to confirm that
  the layout looks correct on each page.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Paul Derscheid 2024-11-07 09:57:10 UTC
Created attachment 174107 [details] [review]
Bug 38379: Remove obsolete Bootstrap classes from installer templates

This patch makes some minor markup changes to the installer and
onboarding templates so that obsolete Bootstrap grid classes are
removed. The patch also adds another breakpoint to the grid classes to
that the content adjusts well at smaller viewport sizes.

To test, apply the patch and rebuild the staff interface CSS.

- Drop and recreate the Koha database. Run 'restart_all' if necessary.
- Navigate to the staff interface. You should be presented with the
  installer login. The form should be centered on the page.
- Log in and follow the installer and onboarding steps to confirm that
  the layout looks correct on each page.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 4 Katrin Fischer 2024-11-08 10:25:04 UTC
Pushed for 24.11!

Well done everyone, thank you!