Bug 37981

Summary: Switch installer/step3.tt form from POST to GET
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: Needs documenting --- QA Contact: Pedro Amorim <pedro.amorim>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, lucas, martin.renvoize, pedro.amorim, phil
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.06
Circulation function:
Bug Depends on:    
Bug Blocks: 37728    
Attachments: Bug 37981: Switch installer/ste3.tt form from POST to GET
Bug 37981: Switch installer/ste3.tt form from POST to GET
Bug 37981: Switch installer/step3.tt form from POST to GET
Bug 37981: Switch installer/step3.tt form from POST to GET

Description Jonathan Druart 2024-09-23 09:03:29 UTC
Caught by test on bug 37728

# $VAR2 = 'koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt:294';
Comment 1 Jonathan Druart 2024-09-23 09:04:42 UTC
Created attachment 171871 [details] [review]
Bug 37981: Switch installer/ste3.tt form from POST to GET

This form does not need to be a POSTed form.

Test plan:
Drop and recreate the DB and run the web installer.
Everything should work, no behaviour change expected.
Comment 2 Phil Ringnalda 2024-09-24 02:18:26 UTC
Created attachment 171910 [details] [review]
Bug 37981: Switch installer/ste3.tt form from POST to GET

This form does not need to be a POSTed form.

Test plan:
Drop and recreate the DB and run the web installer.
Everything should work, no behaviour change expected.

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Testing notes:
https://gitlab.com/-/snippets/1893788#starting-the-web-installer
Comment 3 Phil Ringnalda 2024-09-24 02:57:17 UTC
Created attachment 171914 [details] [review]
Bug 37981: Switch installer/step3.tt form from POST to GET

This form does not need to be a POSTed form.

Test plan:
Drop and recreate the DB and run the web installer.
Everything should work, no behaviour change expected.

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 4 Pedro Amorim 2024-09-24 09:43:15 UTC
Created attachment 171920 [details] [review]
Bug 37981: Switch installer/step3.tt form from POST to GET

This form does not need to be a POSTed form.

Test plan:
Drop and recreate the DB and run the web installer.
Everything should work, no behaviour change expected.

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 5 Pedro Amorim 2024-09-24 09:43:39 UTC
(In reply to Phil Ringnalda from comment #2)
> Testing notes:
> https://gitlab.com/-/snippets/1893788#starting-the-web-installer

Thanks for this link, very useful, bookmarked!
Comment 6 Martin Renvoize (ashimema) 2024-09-30 14:34:25 UTC
Thanks for all the hard work!

Pushed to main for the next 24.11.00 release as RM Assistant
Comment 7 Lucas Gass (lukeg) 2024-11-18 22:32:50 UTC
Backported to 24.05.x for upcoming 24.05.06
Comment 8 Fridolin Somers 2024-12-11 13:40:45 UTC
Not for 23.11.x