Bug 37981 - Switch installer/step3.tt form from POST to GET
Summary: Switch installer/step3.tt form from POST to GET
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Pedro Amorim
URL:
Keywords:
Depends on:
Blocks: 37728
  Show dependency tree / graph
 
Reported: 2024-09-23 09:03 UTC by Jonathan Druart
Modified: 2024-11-18 22:32 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.06
Circulation function:

Attachments
Bug 37981: Switch installer/ste3.tt form from POST to GET (1.37 KB, patch)
2024-09-23 09:04 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 37981: Switch installer/ste3.tt form from POST to GET (1.42 KB, patch)
2024-09-24 02:18 UTC, Phil Ringnalda 		Details | Diff | Splinter Review
Bug 37981: Switch installer/step3.tt form from POST to GET (1.42 KB, patch)
2024-09-24 02:57 UTC, Phil Ringnalda 		Details | Diff | Splinter Review
Bug 37981: Switch installer/step3.tt form from POST to GET (1.48 KB, patch)
2024-09-24 09:43 UTC, Pedro Amorim 		Details | Diff | Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-09-23 09:03:29 UTC 
Caught by test on bug 37728

# $VAR2 = 'koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt:294';
Comment 1 Jonathan Druart 2024-09-23 09:04:42 UTC 
Created attachment 171871 [details] [review]
Bug 37981: Switch installer/ste3.tt form from POST to GET

This form does not need to be a POSTed form.

Test plan:
Drop and recreate the DB and run the web installer.
Everything should work, no behaviour change expected.
Comment 2 Phil Ringnalda 2024-09-24 02:18:26 UTC 
Created attachment 171910 [details] [review]
Bug 37981: Switch installer/ste3.tt form from POST to GET

This form does not need to be a POSTed form.

Test plan:
Drop and recreate the DB and run the web installer.
Everything should work, no behaviour change expected.

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Testing notes:
https://gitlab.com/-/snippets/1893788#starting-the-web-installer
Comment 3 Phil Ringnalda 2024-09-24 02:57:17 UTC 
Created attachment 171914 [details] [review]
Bug 37981: Switch installer/step3.tt form from POST to GET

This form does not need to be a POSTed form.

Test plan:
Drop and recreate the DB and run the web installer.
Everything should work, no behaviour change expected.

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 4 Pedro Amorim 2024-09-24 09:43:15 UTC 
Created attachment 171920 [details] [review]
Bug 37981: Switch installer/step3.tt form from POST to GET

This form does not need to be a POSTed form.

Test plan:
Drop and recreate the DB and run the web installer.
Everything should work, no behaviour change expected.

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 5 Pedro Amorim 2024-09-24 09:43:39 UTC 
(In reply to Phil Ringnalda from comment #2)
> Testing notes:
> https://gitlab.com/-/snippets/1893788#starting-the-web-installer

Thanks for this link, very useful, bookmarked!
Comment 6 Martin Renvoize (ashimema) 2024-09-30 14:34:25 UTC 
Thanks for all the hard work!

Pushed to main for the next 24.11.00 release as RM Assistant
Comment 7 Lucas Gass (lukeg) 2024-11-18 22:32:50 UTC 
Backported to 24.05.x for upcoming 24.05.06