Bug 37983

Summary: "Search a patron" box no longer has auto focus
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: CirculationAssignee: Jonathan Druart <jonathan.druart>
Status: Needs documenting --- QA Contact: Lucas Gass (lukeg) <lucas>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, gmcharlt, jesse, kyle.m.hall, martin.renvoize, phil, wainuiwitikapark
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38676
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.06,23.11.11,22.11.25
Circulation function:
Bug Depends on: 30965    
Bug Blocks:    
Attachments: Bug 37983: Restore auto-focus on patron input when "Schedule a pickup" is selected
Bug 37983: Restore auto-focus on patron input when "Schedule a pickup" is selected
Bug 37983: Restore auto-focus on patron input when "Schedule a pickup" is selected

Description Jonathan Druart 2024-09-23 10:06:37 UTC
In the curbside pickup module, when the "Schedule a pickup" tab is selected we expect the patron search box to get the focus. But it has been broken bug 30965 (which changed the id of the input).
Comment 1 Jonathan Druart 2024-09-23 10:08:57 UTC
Created attachment 171873 [details] [review]
Bug 37983: Restore auto-focus on patron input when "Schedule a pickup" is selected

In the curbside pickup module, when the "Schedule a pickup" tab is selected we expect
the patron search box to get the focus. But it has been broken bug 30965 (which changed the id of the input).

Test plan:
Setup curbside pickup for your library
Go to Circulation > Curbside pickups
Click the last tab
Notice that you can directly search for a patron, the input has the
focus
Comment 2 Phil Ringnalda 2024-09-24 03:06:34 UTC
Created attachment 171915 [details] [review]
Bug 37983: Restore auto-focus on patron input when "Schedule a pickup" is selected

In the curbside pickup module, when the "Schedule a pickup" tab is selected we expect
the patron search box to get the focus. But it has been broken bug 30965 (which changed the id of the input).

Test plan:
Setup curbside pickup for your library
Go to Circulation > Curbside pickups
Click the last tab
Notice that you can directly search for a patron, the input has the
focus

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Testing notes: the tabs looking like a line of jammed-together links is
bug 37761
Comment 3 Lucas Gass (lukeg) 2024-09-24 16:29:53 UTC
Created attachment 171948 [details] [review]
Bug 37983: Restore auto-focus on patron input when "Schedule a pickup" is selected

In the curbside pickup module, when the "Schedule a pickup" tab is selected we expect
the patron search box to get the focus. But it has been broken bug 30965 (which changed the id of the input).

Test plan:
Setup curbside pickup for your library
Go to Circulation > Curbside pickups
Click the last tab
Notice that you can directly search for a patron, the input has the
focus

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Martin Renvoize (ashimema) 2024-09-30 14:34:32 UTC
Thanks for all the hard work!

Pushed to main for the next 24.11.00 release as RM Assistant
Comment 5 Lucas Gass (lukeg) 2024-11-18 22:33:21 UTC
Backported to 24.05.x for upcoming 24.05.06
Comment 6 Fridolin Somers 2024-12-11 13:46:08 UTC
I found another place of "input-patron-cardnumber" so opened Bug 38676
Comment 7 Fridolin Somers 2024-12-11 13:46:38 UTC
Pushed to 23.11.x for 23.11.11
Comment 8 Jesse Maseto 2025-03-31 13:32:32 UTC
This will be pushed to 22.11.x. for 22.11.25