Summary: | Redundant code import in search.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Pedro Amorim <pedro.amorim> |
Component: | Architecture, internals, and plumbing | Assignee: | Pedro Amorim <pedro.amorim> |
Status: | RESOLVED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, lucas, martin.renvoize, shi-yao.wang, wainuiwitikapark |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
24.11.00,24.05.06,23.11.11
|
Circulation function: | |
Bug Depends on: | 17600 | ||
Bug Blocks: | |||
Attachments: |
Bug 38000: Update imports
Bug 38000: Update imports Bug 38000: Update imports Bug 38000: Update imports |
Description
Pedro Amorim
2024-09-24 14:24:25 UTC
Created attachment 171941 [details] [review] Bug 38000: Update imports Noticed this while debugging a search related problem on a live server. This is cosmetic only. I would keep the line as it was and remove the redundant one use C4::Search qw( searchResults enabled_staff_search_views z3950_search_args new_record_from_zebra ); 631 $template->param (z3950_search_params => C4::Search::z3950_search_args($z3950par || $query_desc)); 705 my $marc_record_object = C4::Search::new_record_from_zebra( Created attachment 171945 [details] [review] Bug 38000: Update imports Noticed this while debugging a search related problem on a live server. This is cosmetic only. Created attachment 172006 [details] [review] Bug 38000: Update imports Noticed this while debugging a search related problem on a live server. This is cosmetic only. Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> Created attachment 172052 [details] [review] Bug 38000: Update imports Noticed this while debugging a search related problem on a live server. This is cosmetic only. Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> No sure you are allowed to use those nicely rounded bug numbers for such boring patches! ;) Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant Backported to 24.05.x for upcoming 24.05.06 Pushed to 23.11.x for 23.11.11 Not backporting to 22.11 |