Bug 38000 - Redundant code import in search.pl
Summary: Redundant code import in search.pl
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Pedro Amorim
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-24 14:24 UTC by Pedro Amorim
Modified: 2024-10-02 09:56 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 38000: Update imports (1.18 KB, patch)
2024-09-24 14:25 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 38000: Update imports (853 bytes, patch)
2024-09-24 15:20 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 38000: Update imports (907 bytes, patch)
2024-09-26 18:35 UTC, Shi Yao Wang
Details | Diff | Splinter Review
Bug 38000: Update imports (974 bytes, patch)
2024-09-26 19:33 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2024-09-24 14:24:25 UTC

    
Comment 1 Pedro Amorim 2024-09-24 14:25:19 UTC
Created attachment 171941 [details] [review]
Bug 38000: Update imports

Noticed this while debugging a search related problem on a live server. This is cosmetic only.
Comment 2 Jonathan Druart 2024-09-24 14:58:33 UTC
I would keep the line as it was and remove the redundant one

use C4::Search qw( searchResults enabled_staff_search_views z3950_search_args new_record_from_zebra );

631         $template->param (z3950_search_params => C4::Search::z3950_search_args($z3950par || $query_desc));

705             my $marc_record_object = C4::Search::new_record_from_zebra(
Comment 3 Pedro Amorim 2024-09-24 15:20:11 UTC
Created attachment 171945 [details] [review]
Bug 38000: Update imports

Noticed this while debugging a search related problem on a live server. This is cosmetic only.
Comment 4 Shi Yao Wang 2024-09-26 18:35:07 UTC
Created attachment 172006 [details] [review]
Bug 38000: Update imports

Noticed this while debugging a search related problem on a live server. This is cosmetic only.

Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com>
Comment 5 Martin Renvoize (ashimema) 2024-09-26 19:33:04 UTC
Created attachment 172052 [details] [review]
Bug 38000: Update imports

Noticed this while debugging a search related problem on a live server. This is cosmetic only.

Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 6 Jonathan Druart 2024-09-30 13:17:19 UTC
No sure you are allowed to use those nicely rounded bug numbers for such boring patches!


;)
Comment 7 Martin Renvoize (ashimema) 2024-10-02 09:56:45 UTC
Thanks for all the hard work!

Pushed to main for the next 24.11.00 release as RM Assistant