Bug 38013

Summary:	Some checkin messages on checkins page lack specific CSS classes
Product:	Koha	Reporter:	Andrew Fuerste-Henry <andrew>
Component:	Circulation	Assignee:	Andrew Fuerste-Henry <andrew>
Status:	RESOLVED FIXED	QA Contact:	Martin Renvoize (ashimema) <martin.renvoize>
Severity:	normal
Priority:	P5 - low	CC:	blawlor, gmcharlt, kyle.m.hall, lucas, martin.renvoize
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	24.11.00
Circulation function:
Attachments:	Bug 38013: Add classes to messages in returns.tt Bug 38013: Add classes to messages in returns.tt Bug 38013: Add classes to messages in returns.tt

Description Andrew Fuerste-Henry 2024-09-26 14:29:18 UTC

Most of the messages that Koha might display on the checkin page have distinct classes. We do not apply a specific class when a checkout had an issue note:

https://github.com/Koha-Community/Koha/blob/b4054dbb1578349cd1b8caa8fac9cbe6e32d20ea/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt#L177

Or when the patron has fines:

https://github.com/Koha-Community/Koha/blob/b4054dbb1578349cd1b8caa8fac9cbe6e32d20ea/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt#L187

We should do so in both cases.

Comment 1 Andrew Fuerste-Henry 2024-09-27 14:08:51 UTC

Created attachment 172116 [details] [review]
Bug 38013: Add classes to messages in returns.tt

To test:
1 - enable FineNotifyAtCheckin
2 - enable AllowCheckoutNotes
3 - check out an item to a patron with fines on their account
4 - check out an item and place a checkout note on it
5 - check each item in, confirm each produces a message with the classes alert, alert-info, and alert-warning
6 - apply patch, restart_all
7 - repeat steps 3 and 4
8 - check items in, confirm messages now include issue-note and patron-fines classes

Comment 2 Brendan Lawlor 2024-09-27 15:55:14 UTC

Created attachment 172136 [details] [review]
Bug 38013: Add classes to messages in returns.tt

To test:
1 - enable FineNotifyAtCheckin
2 - enable AllowCheckoutNotes
3 - check out an item to a patron with fines on their account
4 - check out an item and place a checkout note on it
5 - check each item in, confirm each produces a message with the classes alert, alert-info, and alert-warning
6 - apply patch, restart_all
7 - repeat steps 3 and 4
8 - check items in, confirm messages now include issue-note and patron-fines classes

Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>

Comment 3 Brendan Lawlor 2024-09-27 15:59:06 UTC

testing notes:
To easily create a checkout with fines
Define fine rules
Specify a backdated due date at checkout
Run fines.pl cronjob

Comment 4 Martin Renvoize (ashimema) 2024-10-28 11:51:14 UTC

Created attachment 173526 [details] [review]
Bug 38013: Add classes to messages in returns.tt

To test:
1 - enable FineNotifyAtCheckin
2 - enable AllowCheckoutNotes
3 - check out an item to a patron with fines on their account
4 - check out an item and place a checkout note on it
5 - check each item in, confirm each produces a message with the classes alert, alert-info, and alert-warning
6 - apply patch, restart_all
7 - repeat steps 3 and 4
8 - check items in, confirm messages now include issue-note and patron-fines classes

Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Comment 5 Katrin Fischer 2024-10-29 07:54:22 UTC

Pushed for 24.11!

Well done everyone, thank you!

Comment 6 Lucas Gass (lukeg) 2024-11-20 23:35:48 UTC

Merge conflicts with 24.05.x, no backport.