Most of the messages that Koha might display on the checkin page have distinct classes. We do not apply a specific class when a checkout had an issue note: https://github.com/Koha-Community/Koha/blob/b4054dbb1578349cd1b8caa8fac9cbe6e32d20ea/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt#L177 Or when the patron has fines: https://github.com/Koha-Community/Koha/blob/b4054dbb1578349cd1b8caa8fac9cbe6e32d20ea/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt#L187 We should do so in both cases.
Created attachment 172116 [details] [review] Bug 38013: Add classes to messages in returns.tt To test: 1 - enable FineNotifyAtCheckin 2 - enable AllowCheckoutNotes 3 - check out an item to a patron with fines on their account 4 - check out an item and place a checkout note on it 5 - check each item in, confirm each produces a message with the classes alert, alert-info, and alert-warning 6 - apply patch, restart_all 7 - repeat steps 3 and 4 8 - check items in, confirm messages now include issue-note and patron-fines classes
Created attachment 172136 [details] [review] Bug 38013: Add classes to messages in returns.tt To test: 1 - enable FineNotifyAtCheckin 2 - enable AllowCheckoutNotes 3 - check out an item to a patron with fines on their account 4 - check out an item and place a checkout note on it 5 - check each item in, confirm each produces a message with the classes alert, alert-info, and alert-warning 6 - apply patch, restart_all 7 - repeat steps 3 and 4 8 - check items in, confirm messages now include issue-note and patron-fines classes Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
testing notes: To easily create a checkout with fines Define fine rules Specify a backdated due date at checkout Run fines.pl cronjob
Created attachment 173526 [details] [review] Bug 38013: Add classes to messages in returns.tt To test: 1 - enable FineNotifyAtCheckin 2 - enable AllowCheckoutNotes 3 - check out an item to a patron with fines on their account 4 - check out an item and place a checkout note on it 5 - check each item in, confirm each produces a message with the classes alert, alert-info, and alert-warning 6 - apply patch, restart_all 7 - repeat steps 3 and 4 8 - check items in, confirm messages now include issue-note and patron-fines classes Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Pushed for 24.11! Well done everyone, thank you!
Merge conflicts with 24.05.x, no backport.