Bug 38016

Summary: Relabel booking precaution column heading in circulation rules tables
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: CirculationAssignee: Aleisha Amohia <aleisha>
Status: RESOLVED FIXED QA Contact: Kyle M Hall (khall) <kyle>
Severity: trivial    
Priority: P5 - low CC: aleisha, caroline.cyr-la-rose, ddaghita, edward.m.veal, george, gmcharlt, heather, kkrueger, kyle.m.hall, kyle, lucas, marie-luce.laflamme, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: Sponsored Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:
Bug Depends on: 34440    
Bug Blocks:    
Attachments: Bug 38016: Rename booking circulation rules
Bug 38016: Rename booking circulation rules
Bug 38016: Rename booking circulation rules

Description Katrin Fischer 2024-09-26 17:50:35 UTC
In the circulation rules there are 2 tables with 2 new columns named:

* booking preparation period
* booking precaution period

While the first is before the booking, the second is after the booking is returned, but that's not clearly reflected in the name.

Some alternative suggestions we came up with:

A)
* booking lead period
* booking trail period

B)
* booking warm-up period
* booking cool-down period

C)
* booking pre-buffer (days)
* booking post-buffer (days)
Comment 1 George Williams (NEKLS) 2024-09-26 17:52:42 UTC
How about:

D)
* booking pre-processing
* booking post-processing
Comment 2 Aleisha Amohia 2024-09-26 17:55:39 UTC
Also 

E)

* pre-booking buffer (days)
* post-booking buffer (days)
Comment 3 Heather Rommens 2024-09-26 17:57:53 UTC
I agree that this relabeling is needed. How about something like:
  *Booking preparation period
  *Booking recovery period
Comment 4 Katrin Fischer 2024-09-26 17:58:58 UTC
(In reply to Heather Rommens from comment #3)
> I agree that this relabeling is needed. How about something like:
>   *Booking preparation period
>   *Booking recovery period

We are naming this option F :)
Comment 5 Caroline Cyr La Rose 2024-09-26 18:05:17 UTC
(In reply to George Williams (NEKLS) from comment #1)
> How about:
> 
> D)
> * booking pre-processing
> * booking post-processing

I like this the best, maybe with a slight variation

D.a)

* pre-booking processing
* post-booking processing 

But I'd be fine with D) as is
Comment 6 Marie-Luce Laflamme 2024-09-26 20:05:35 UTC
(In reply to George Williams (NEKLS) from comment #1)
> How about:
> 
> D)
> * booking pre-processing
> * booking post-processing

I prefer this version, as it seems clearer to a non-native English speaker.
Comment 7 Aleisha Amohia 2024-09-27 15:04:24 UTC
Created attachment 172119 [details] [review]
Bug 38016: Rename booking circulation rules

This enhancement renames the bookings circulation rules to better describe what they do.

To test:

1. Go to Koha Administration -> Circulation and fines rules
2. Scroll to the 'Default holds and bookings policies by item type' section
3. Notice the bookings rules in this table:
  - Booking preparation period
  - Booking precaution period
4. Apply the patch and refresh the page
5. Confirm the bookings have been renamed to:
  - Booking pre-processing (days)
  - Booking post-processing (days)
6. Confirm these names make sense and it is clear what the rules are used for and how they are applied
7. Put values in the input fields for these rules and confirm saving a rule works as expected

Sponsored-by: Catalyst IT
Comment 8 David Nind 2024-09-27 20:47:58 UTC
Created attachment 172182 [details] [review]
Bug 38016: Rename booking circulation rules

This enhancement renames the bookings circulation rules to better describe what they do.

To test:

1. Go to Koha Administration -> Circulation and fines rules
2. Scroll to the 'Default holds and bookings policies by item type' section
3. Notice the bookings rules in this table:
  - Booking preparation period
  - Booking precaution period
4. Apply the patch and refresh the page
5. Confirm the bookings have been renamed to:
  - Booking pre-processing (days)
  - Booking post-processing (days)
6. Confirm these names make sense and it is clear what the rules are used for and how they are applied
7. Put values in the input fields for these rules and confirm saving a rule works as expected

Sponsored-by: Catalyst IT
Signed-off-by: David Nind <david@davidnind.com>
Comment 9 Kyle M Hall (khall) 2024-09-27 20:58:02 UTC
Created attachment 172184 [details] [review]
Bug 38016: Rename booking circulation rules

This enhancement renames the bookings circulation rules to better describe what they do.

To test:

1. Go to Koha Administration -> Circulation and fines rules
2. Scroll to the 'Default holds and bookings policies by item type' section
3. Notice the bookings rules in this table:
  - Booking preparation period
  - Booking precaution period
4. Apply the patch and refresh the page
5. Confirm the bookings have been renamed to:
  - Booking pre-processing (days)
  - Booking post-processing (days)
6. Confirm these names make sense and it is clear what the rules are used for and how they are applied
7. Put values in the input fields for these rules and confirm saving a rule works as expected

Sponsored-by: Catalyst IT
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 10 Martin Renvoize (ashimema) 2024-10-02 09:53:52 UTC
(In reply to Heather Rommens from comment #3)
> I agree that this relabeling is needed. How about something like:
>   *Booking preparation period
>   *Booking recovery period

I personally like this one the best as it's how I saw them functioning in real life.. i.e 'preparation' is time it takes for library to 'do stuff'.. i.e transfers, checking for defects etc etc, whilst 'recovery' is the extra time added to the loan to make sure the item is returned in suitable time.. it's a buffer for the patron being a bit late.
Comment 11 Martin Renvoize (ashimema) 2024-10-02 09:55:11 UTC
I'd like Kristi or someone else from Cuyahoga to weight in as they're about to actively use the feature so understood the original requirements best.

I'm not actively against any changes.. just want to make sure they're descriptive in their intended use.
Comment 12 Kristi 2024-10-02 12:57:43 UTC
I'll check around here this morning.
Comment 13 Kristi 2024-10-02 17:24:02 UTC
Checked with others at CCPL. We agree that the option selected  (- Booking pre-processing (days) - Booking post-processing (days)) is clear and works for our needs.
Comment 14 Aleisha Amohia 2024-10-02 18:42:11 UTC
(In reply to Kristi from comment #13)
> Checked with others at CCPL. We agree that the option selected  (- Booking
> pre-processing (days) - Booking post-processing (days)) is clear and works
> for our needs.

Thanks Kristi and Martin - really helpful to get your feedback!
Comment 15 Katrin Fischer 2024-10-11 10:18:28 UTC
It was fun to work on that with you all at the Kohacon24 hackfest!
Comment 16 Katrin Fischer 2024-10-11 10:27:50 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 17 Aleisha Amohia 2024-10-13 20:07:44 UTC
Woohoo team effort!
Comment 18 Lucas Gass (lukeg) 2024-11-18 23:18:19 UTC
Missing 24.05.x deps, no backport.