In the circulation rules there are 2 tables with 2 new columns named: * booking preparation period * booking precaution period While the first is before the booking, the second is after the booking is returned, but that's not clearly reflected in the name. Some alternative suggestions we came up with: A) * booking lead period * booking trail period B) * booking warm-up period * booking cool-down period C) * booking pre-buffer (days) * booking post-buffer (days)
How about: D) * booking pre-processing * booking post-processing
Also E) * pre-booking buffer (days) * post-booking buffer (days)
I agree that this relabeling is needed. How about something like: *Booking preparation period *Booking recovery period
(In reply to Heather Rommens from comment #3) > I agree that this relabeling is needed. How about something like: > *Booking preparation period > *Booking recovery period We are naming this option F :)
(In reply to George Williams (NEKLS) from comment #1) > How about: > > D) > * booking pre-processing > * booking post-processing I like this the best, maybe with a slight variation D.a) * pre-booking processing * post-booking processing But I'd be fine with D) as is
(In reply to George Williams (NEKLS) from comment #1) > How about: > > D) > * booking pre-processing > * booking post-processing I prefer this version, as it seems clearer to a non-native English speaker.
Created attachment 172119 [details] [review] Bug 38016: Rename booking circulation rules This enhancement renames the bookings circulation rules to better describe what they do. To test: 1. Go to Koha Administration -> Circulation and fines rules 2. Scroll to the 'Default holds and bookings policies by item type' section 3. Notice the bookings rules in this table: - Booking preparation period - Booking precaution period 4. Apply the patch and refresh the page 5. Confirm the bookings have been renamed to: - Booking pre-processing (days) - Booking post-processing (days) 6. Confirm these names make sense and it is clear what the rules are used for and how they are applied 7. Put values in the input fields for these rules and confirm saving a rule works as expected Sponsored-by: Catalyst IT
Created attachment 172182 [details] [review] Bug 38016: Rename booking circulation rules This enhancement renames the bookings circulation rules to better describe what they do. To test: 1. Go to Koha Administration -> Circulation and fines rules 2. Scroll to the 'Default holds and bookings policies by item type' section 3. Notice the bookings rules in this table: - Booking preparation period - Booking precaution period 4. Apply the patch and refresh the page 5. Confirm the bookings have been renamed to: - Booking pre-processing (days) - Booking post-processing (days) 6. Confirm these names make sense and it is clear what the rules are used for and how they are applied 7. Put values in the input fields for these rules and confirm saving a rule works as expected Sponsored-by: Catalyst IT Signed-off-by: David Nind <david@davidnind.com>
Created attachment 172184 [details] [review] Bug 38016: Rename booking circulation rules This enhancement renames the bookings circulation rules to better describe what they do. To test: 1. Go to Koha Administration -> Circulation and fines rules 2. Scroll to the 'Default holds and bookings policies by item type' section 3. Notice the bookings rules in this table: - Booking preparation period - Booking precaution period 4. Apply the patch and refresh the page 5. Confirm the bookings have been renamed to: - Booking pre-processing (days) - Booking post-processing (days) 6. Confirm these names make sense and it is clear what the rules are used for and how they are applied 7. Put values in the input fields for these rules and confirm saving a rule works as expected Sponsored-by: Catalyst IT Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(In reply to Heather Rommens from comment #3) > I agree that this relabeling is needed. How about something like: > *Booking preparation period > *Booking recovery period I personally like this one the best as it's how I saw them functioning in real life.. i.e 'preparation' is time it takes for library to 'do stuff'.. i.e transfers, checking for defects etc etc, whilst 'recovery' is the extra time added to the loan to make sure the item is returned in suitable time.. it's a buffer for the patron being a bit late.
I'd like Kristi or someone else from Cuyahoga to weight in as they're about to actively use the feature so understood the original requirements best. I'm not actively against any changes.. just want to make sure they're descriptive in their intended use.
I'll check around here this morning.
Checked with others at CCPL. We agree that the option selected (- Booking pre-processing (days) - Booking post-processing (days)) is clear and works for our needs.
(In reply to Kristi from comment #13) > Checked with others at CCPL. We agree that the option selected (- Booking > pre-processing (days) - Booking post-processing (days)) is clear and works > for our needs. Thanks Kristi and Martin - really helpful to get your feedback!
It was fun to work on that with you all at the Kohacon24 hackfest!
Pushed for 24.11! Well done everyone, thank you!