Summary: | Not all self checkout errors behave the same | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Self checkout | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | Needs documenting --- | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | normal | ||
Priority: | P5 - low | CC: | cj.lynce, fridolin.somers, martin.renvoize, wainuiwitikapark |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
24.11.00,24.05.06
|
Circulation function: | |
Attachments: |
Bug 38041: Pass hide_main for all needsconfirm warnings in SCO
Bug 38041: Pass hide_main for all needsconfirm warnings in SCO Bug 38041: Pass hide_main for all needsconfirm warnings in SCO |
Description
Lucas Gass (lukeg)
2024-09-30 16:58:31 UTC
sco-main.pl passes a hide_main template variable when issuing is impossible. ( Determined by CanBookBeIssued ) Other problems get needsconfirm ( see CanBookBeIssued for a list ) sco-main.pl should also pass the 'hide_main' variable when the issue is needsconfirm. Created attachment 172236 [details] [review] Bug 38041: Pass hide_main for all needsconfirm warnings in SCO To test: 1. APPLY PATCH and restart_all 2. Make sure the following errors when issuing in SCO show just the error, no other info. on screen: DEBT RENEW_ISSUE ISSUED_TO_ANOTHER RESERVED TRANSFERRED INVALID_DATE ( cant test in SCO ) TOO_MANY RECALLED Created attachment 172531 [details] [review] Bug 38041: Pass hide_main for all needsconfirm warnings in SCO To test: 1. APPLY PATCH and restart_all 2. Make sure the following errors when issuing in SCO show just the error, no other info. on screen: DEBT RENEW_ISSUE ISSUED_TO_ANOTHER RESERVED TRANSFERRED INVALID_DATE ( cant test in SCO ) TOO_MANY RECALLED Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org> Patch works great, tested the various listed situations and all show just the error, no other info. Created attachment 173525 [details] [review] Bug 38041: Pass hide_main for all needsconfirm warnings in SCO To test: 1. APPLY PATCH and restart_all 2. Make sure the following errors when issuing in SCO show just the error, no other info. on screen: DEBT RENEW_ISSUE ISSUED_TO_ANOTHER RESERVED TRANSFERRED INVALID_DATE ( cant test in SCO ) TOO_MANY RECALLED Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.06 Does not apply easy on 23.11.x please provide specific patch if you can Not backporting to 22.11 unless requested |