Bug 38041 - Not all self checkout errors behave the same
Summary: Not all self checkout errors behave the same
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Self checkout (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-30 16:58 UTC by Lucas Gass (lukeg)
Modified: 2024-12-13 15:23 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.06
Circulation function:


Attachments
Bug 38041: Pass hide_main for all needsconfirm warnings in SCO (1.17 KB, patch)
2024-09-30 19:57 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 38041: Pass hide_main for all needsconfirm warnings in SCO (1.23 KB, patch)
2024-10-08 15:00 UTC, CJ Lynce
Details | Diff | Splinter Review
Bug 38041: Pass hide_main for all needsconfirm warnings in SCO (1.29 KB, patch)
2024-10-28 11:49 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2024-09-30 16:58:31 UTC
For example: 

1. Enable SCO and go to the SCO module
2. Attempt to checkout a non-existent barcode. 
3. See the error that appears, nothing else.
4. Attempt to checkout something that is already checked out.
5. The error is much the same but you still see all parts of the SCO module.

This is a problem for some libraries attempting smooth user experience for SCO users.
Comment 1 Lucas Gass (lukeg) 2024-09-30 19:53:49 UTC
sco-main.pl passes a hide_main template variable when issuing is impossible. ( Determined by CanBookBeIssued )

Other problems get needsconfirm ( see CanBookBeIssued for a list )

sco-main.pl should also pass the 'hide_main' variable when the issue is needsconfirm.
Comment 2 Lucas Gass (lukeg) 2024-09-30 19:57:27 UTC
Created attachment 172236 [details] [review]
Bug 38041: Pass hide_main for all needsconfirm warnings in SCO

To test:
1. APPLY PATCH and restart_all
2. Make sure the following errors when issuing in SCO show just the error, no other info. on screen:
DEBT
RENEW_ISSUE
ISSUED_TO_ANOTHER
RESERVED
TRANSFERRED
INVALID_DATE ( cant test in SCO )
TOO_MANY
RECALLED
Comment 3 CJ Lynce 2024-10-08 15:00:10 UTC
Created attachment 172531 [details] [review]
Bug 38041: Pass hide_main for all needsconfirm warnings in SCO

To test:
1. APPLY PATCH and restart_all
2. Make sure the following errors when issuing in SCO show just the error, no other info. on screen:
DEBT
RENEW_ISSUE
ISSUED_TO_ANOTHER
RESERVED
TRANSFERRED
INVALID_DATE ( cant test in SCO )
TOO_MANY
RECALLED

Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org>
Comment 4 CJ Lynce 2024-10-08 15:02:08 UTC
Patch works great, tested the various listed situations and all show just the error, no other info.
Comment 5 Martin Renvoize (ashimema) 2024-10-28 11:49:46 UTC
Created attachment 173525 [details] [review]
Bug 38041: Pass hide_main for all needsconfirm warnings in SCO

To test:
1. APPLY PATCH and restart_all
2. Make sure the following errors when issuing in SCO show just the error, no other info. on screen:
DEBT
RENEW_ISSUE
ISSUED_TO_ANOTHER
RESERVED
TRANSFERRED
INVALID_DATE ( cant test in SCO )
TOO_MANY
RECALLED

Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 6 Katrin Fischer 2024-10-29 07:54:25 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 7 Lucas Gass (lukeg) 2024-11-22 21:17:58 UTC
Backported to 24.05.x for upcoming 24.05.06
Comment 8 Fridolin Somers 2024-12-13 15:23:53 UTC
Does not apply easy on 23.11.x
please provide specific patch if you can