Bug 38066

Summary:	Pop-up window footers can block page content
Product:	Koha	Reporter:	Phil Ringnalda <phil>
Component:	Templates	Assignee:	Owen Leonard <oleonard>
Status:	Pushed to main ---	QA Contact:	Martin Renvoize (ashimema) <martin.renvoize>
Severity:	normal
Priority:	P5 - low	CC:	david, martin.renvoize
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:	This fixes the display of some dialog boxes, such as the authority record search plugin when editing 100$a, so that the content at the bottom (such as search results) is not obscured by the footer navigation.	Version(s) released in:	24.11.00
Circulation function:
Bug Depends on:	35857
Bug Blocks:
Attachments:	Bug 38066: Popup window footers can block page content Bug 38066: Popup window footers can block page content Bug 38066: Popup window footers can block page content

Description Phil Ringnalda 2024-10-02 18:54:46 UTC

Bug 35857 gave the authority lookup popup window a floating footer with the choose, clear form, and close window buttons, but it didn't give the window contents enough space to display it without blocking content.

Steps to reproduce:
1. Cataloging - New record
2. Tab 6 - in 650 subfield a type the letter a and click the postcard with a pencil Tag editor icon to the right of the input
3. In the popup window, scroll to the bottom

Expected result: The paging controls at the bottom of the first page of results, and the "Back to top" arrow are completely visible

Actual result: Half the "Back to top" arrow and maybe 20% of the paging controls are visible

Comment 1 Owen Leonard 2024-10-21 18:48:05 UTC

Created attachment 173079 [details] [review]
Bug 38066: Popup window footers can block page content

The staff interface's default <body> padding is enough to accommmodate
the langugage-selection footer but not the taller fixed footer on pop-up
window pages. This patch adds some CSS to increase the padding on those
pages to prevent page content from being obscured by the footer
navigation.

The patch also adjusts the CSS of the "Back to top" arrow so that it
isn't hidden by fixed footer.

To test, apply the patch and rebuild the staff interface CSS.

- In the staff client, go to Cataloging -> New record.
- In tab one, click the plugin button on tag 100 subfield a.
- Perform an authority search which will return results.
- Scroll down to the bottom of the window and confirm that the last
  lines of the search results are not obscured by the footer.

This change should apply to all pop-up windows which include the same
fixed footer markup, e.g. any cataloging plugin; the transfer order
window; vendor search when adding a subscription, etc.

Sponsored-by: Athens County Public Libraries

Comment 2 David Nind 2024-10-21 19:47:27 UTC

Created attachment 173080 [details] [review]
Bug 38066: Popup window footers can block page content

The staff interface's default <body> padding is enough to accommmodate
the langugage-selection footer but not the taller fixed footer on pop-up
window pages. This patch adds some CSS to increase the padding on those
pages to prevent page content from being obscured by the footer
navigation.

The patch also adjusts the CSS of the "Back to top" arrow so that it
isn't hidden by fixed footer.

To test, apply the patch and rebuild the staff interface CSS.

- In the staff client, go to Cataloging -> New record.
- In tab one, click the plugin button on tag 100 subfield a.
- Perform an authority search which will return results.
- Scroll down to the bottom of the window and confirm that the last
  lines of the search results are not obscured by the footer.

This change should apply to all pop-up windows which include the same
fixed footer markup, e.g. any cataloging plugin; the transfer order
window; vendor search when adding a subscription, etc.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>

Comment 3 Martin Renvoize (ashimema) 2024-10-28 10:41:42 UTC

Created attachment 173504 [details] [review]
Bug 38066: Popup window footers can block page content

The staff interface's default <body> padding is enough to accommmodate
the langugage-selection footer but not the taller fixed footer on pop-up
window pages. This patch adds some CSS to increase the padding on those
pages to prevent page content from being obscured by the footer
navigation.

The patch also adjusts the CSS of the "Back to top" arrow so that it
isn't hidden by fixed footer.

To test, apply the patch and rebuild the staff interface CSS.

- In the staff client, go to Cataloging -> New record.
- In tab one, click the plugin button on tag 100 subfield a.
- Perform an authority search which will return results.
- Scroll down to the bottom of the window and confirm that the last
  lines of the search results are not obscured by the footer.

This change should apply to all pop-up windows which include the same
fixed footer markup, e.g. any cataloging plugin; the transfer order
window; vendor search when adding a subscription, etc.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Comment 4 Katrin Fischer 2024-10-29 07:54:28 UTC

Pushed for 24.11!

Well done everyone, thank you!