Summary: | Pop-up window footers can block page content | ||
---|---|---|---|
Product: | Koha | Reporter: | Phil Ringnalda <phil> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | RESOLVED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, lucas, martin.renvoize, nugged |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This fixes the display of some dialog boxes, such as the authority record search plugin when editing 100$a, so that the content at the bottom (such as search results) is not obscured by the footer navigation.
|
|
Version(s) released in: |
24.11.00
|
Circulation function: | |
Bug Depends on: | 35857 | ||
Bug Blocks: | |||
Attachments: |
Bug 38066: Popup window footers can block page content
Bug 38066: Popup window footers can block page content Bug 38066: Popup window footers can block page content |
Description
Phil Ringnalda
2024-10-02 18:54:46 UTC
Created attachment 173079 [details] [review] Bug 38066: Popup window footers can block page content The staff interface's default <body> padding is enough to accommmodate the langugage-selection footer but not the taller fixed footer on pop-up window pages. This patch adds some CSS to increase the padding on those pages to prevent page content from being obscured by the footer navigation. The patch also adjusts the CSS of the "Back to top" arrow so that it isn't hidden by fixed footer. To test, apply the patch and rebuild the staff interface CSS. - In the staff client, go to Cataloging -> New record. - In tab one, click the plugin button on tag 100 subfield a. - Perform an authority search which will return results. - Scroll down to the bottom of the window and confirm that the last lines of the search results are not obscured by the footer. This change should apply to all pop-up windows which include the same fixed footer markup, e.g. any cataloging plugin; the transfer order window; vendor search when adding a subscription, etc. Sponsored-by: Athens County Public Libraries Created attachment 173080 [details] [review] Bug 38066: Popup window footers can block page content The staff interface's default <body> padding is enough to accommmodate the langugage-selection footer but not the taller fixed footer on pop-up window pages. This patch adds some CSS to increase the padding on those pages to prevent page content from being obscured by the footer navigation. The patch also adjusts the CSS of the "Back to top" arrow so that it isn't hidden by fixed footer. To test, apply the patch and rebuild the staff interface CSS. - In the staff client, go to Cataloging -> New record. - In tab one, click the plugin button on tag 100 subfield a. - Perform an authority search which will return results. - Scroll down to the bottom of the window and confirm that the last lines of the search results are not obscured by the footer. This change should apply to all pop-up windows which include the same fixed footer markup, e.g. any cataloging plugin; the transfer order window; vendor search when adding a subscription, etc. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Created attachment 173504 [details] [review] Bug 38066: Popup window footers can block page content The staff interface's default <body> padding is enough to accommmodate the langugage-selection footer but not the taller fixed footer on pop-up window pages. This patch adds some CSS to increase the padding on those pages to prevent page content from being obscured by the footer navigation. The patch also adjusts the CSS of the "Back to top" arrow so that it isn't hidden by fixed footer. To test, apply the patch and rebuild the staff interface CSS. - In the staff client, go to Cataloging -> New record. - In tab one, click the plugin button on tag 100 subfield a. - Perform an authority search which will return results. - Scroll down to the bottom of the window and confirm that the last lines of the search results are not obscured by the footer. This change should apply to all pop-up windows which include the same fixed footer markup, e.g. any cataloging plugin; the transfer order window; vendor search when adding a subscription, etc. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.06 Can't build my .deb on 24.05.x because of: Message: koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss Error: Undefined variable. 5025 │ z-index: $zindex-tooltip; ... is it because it's not fully backported, or I missed some steps in build? To append to last comment about backport to 24.05.x: I changed: koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss -– @@ -5022,7 +5022,7 @@ div .suggestion_note { position: fixed; bottom: 40px; right: 40px; - z-index: $zindex-tooltip; + z-index: 1080; } @media only screen and ( max-width: 1200px ) { -– and managed to build .deb (In reply to Andrii Nugged from comment #6) > Can't build my .deb on 24.05.x because of: > > Message: > koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss > Error: Undefined variable. > 5025 │ z-index: $zindex-tooltip; > > > ... is it because it's not fully backported, or I missed some steps in build? I shouldn't have backported this to 24.05.x because there is no $zindex-tooltip in that version, I am reverting this. This one is now reverted from 24.05.x. Backported to 24.05.x for upcoming 24.05.06 |