| Summary: | Table settings not saving | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | System Administration | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | RESOLVED FIXED | QA Contact: | Nick Clemens (kidclamp) <nick> |
| Severity: | critical | ||
| Priority: | P5 - low | CC: | gmcharlt, lucas, martin.renvoize, nick |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 37955 | ||
| Bug Blocks: | 38107 | ||
| Attachments: |
Bug 38069: (bug 37955 follow-up) Fix edition of table settings
Bug 38069: (bug 37955 follow-up) Fix edition of table settings Bug 38069: Fix jump to the correct table Bug 38069: (follow-up) Fix jump to the correct table |
||
|
Description
Jonathan Druart
2024-10-03 07:52:47 UTC
Created attachment 172335 [details] [review] Bug 38069: (bug 37955 follow-up) Fix edition of table settings The form cannot longer be saved, and no appear appear (nothing in log, nothing on the UI) This is coming from bug 37955 where we modify the table_id to fix anchors, but we didn't care of the rest of the code using this TT variable. This patch suggests to replace # and _ with | Test plan: Confirm that the form can be edited, saved, and that it is taken correctly into account. Created attachment 172364 [details] [review] Bug 38069: (bug 37955 follow-up) Fix edition of table settings The form cannot longer be saved, and no appear appear (nothing in log, nothing on the UI) This is coming from bug 37955 where we modify the table_id to fix anchors, but we didn't care of the rest of the code using this TT variable. This patch suggests to replace # and _ with | Test plan: Confirm that the form can be edited, saved, and that it is taken correctly into account. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Trivial, PQA Pushed for 24.11! Well done everyone, thank you! Created attachment 174462 [details] [review] Bug 38069: Fix jump to the correct table Picked follow-up "Fix jump to correct table" for main. Created attachment 174681 [details] [review] Bug 38069: (follow-up) Fix jump to the correct table (In reply to Jonathan Druart from comment #7) > Created attachment 174681 [details] [review] [review] > Bug 38069: (follow-up) Fix jump to the correct table Fixes JS error "Uncaught Error: Syntax error, unrecognized expression: #detail|holdings_table" Picked the last patch "(follow-up) Fix jump to correct table" for main. Not needed in 24.05.x |