Summary: | Regression in print notices | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
Component: | Staff interface | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
Status: | Pushed to stable --- | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | critical | ||
Priority: | P5 - low | CC: | alexbuckley, david, gmcharlt, oleonard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This fixes a regression from the Boostrap 5 upgrade for print notices. Each notice is now on its own page, instead of running one after the other without a page break (when running gather_print_notices.pl with HTML file output). (This is related to the OPAC and staff interface Bootstrap 5 upgrade in Koha 24.11.)
|
|
Version(s) released in: |
25.05.00,24.11.02
|
Circulation function: | |
Bug Depends on: | 35402 | ||
Bug Blocks: | |||
Attachments: |
Bug 38070: Revert class change so notices print one per page
Bug 38070: Revert class change so notices print one per page |
Description
Martin Renvoize (ashimema)
2024-10-03 09:45:29 UTC
Side question.. The template here and the circ/printslips.tt template achieve the same result using different methods. This one adds `page-break-after: always` to the containing div of the notice whilst printslips.tt adds an empty div after each slip div and adds `break-after: page` to that. Any thoughts on which method we should use consistently? Created attachment 172361 [details] [review] Bug 38070: Revert class change so notices print one per page This patch reverses the bootstrap 5 find and replace for the 'message' class. In this file the message class didn't refer to the bootstrap themeing but rather is used for applying `page-break-after: always` to these elements. Test plan 1) Line up some print notices 2) Run gather_print_notices.pl with html file output 3) Open the output file 4) Print the page to invoke the page break css 5) Note that with the patch each notice is on it's own page, without the patch all the notices run one after the other on the same page. Created attachment 174981 [details] [review] Bug 38070: Revert class change so notices print one per page This patch reverses the bootstrap 5 find and replace for the 'message' class. In this file the message class didn't refer to the bootstrap themeing but rather is used for applying `page-break-after: always` to these elements. Test plan 1) Line up some print notices 2) Run gather_print_notices.pl with html file output 3) Open the output file 4) Print the page to invoke the page break css 5) Note that with the patch each notice is on it's own page, without the patch all the notices run one after the other on the same page. Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Pushed for 25.05! Well done everyone, thank you! Nice work everyone! Pushed to 24.11.x for 24.11.01 not backporting to 24.05.x unless requested - dependency not in 24.05 |