Bug 38070 - Regression in print notices
Summary: Regression in print notices
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Martin Renvoize (ashimema)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-03 09:45 UTC by Martin Renvoize (ashimema)
Modified: 2024-11-25 16:30 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 38070: Revert class change so notices print one per page (1.47 KB, patch)
2024-10-03 14:49 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 38070: Revert class change so notices print one per page (1.53 KB, patch)
2024-11-25 16:30 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2024-10-03 09:45:29 UTC
I think we've got a regression in the print notices since bootstrap 5.

I noticed whilst working on another bug, that we replaced 'dialog message' with 'alert alert-info' classes in batch/print-notices.tt

However, we didn't update the additional CSS rules above that add `page-break-after: always` onto the 'message' class.

As such, I believe we'll no longe print one notice per page.
Comment 1 Martin Renvoize (ashimema) 2024-10-03 10:48:24 UTC
Side question..

The template here and the circ/printslips.tt template achieve the same result using different methods.

This one adds `page-break-after: always` to the containing div of the notice whilst printslips.tt adds an empty div after each slip div and adds `break-after: page` to that.

Any thoughts on which method we should use consistently?
Comment 2 Martin Renvoize (ashimema) 2024-10-03 14:49:13 UTC
Created attachment 172361 [details] [review]
Bug 38070: Revert class change so notices print one per page

This patch reverses the bootstrap 5 find and replace for the 'message'
class.

In this file the message class didn't refer to the bootstrap themeing
but rather is used for applying `page-break-after: always` to these
elements.

Test plan
1) Line up some print notices
2) Run gather_print_notices.pl with html file output
3) Open the output file
4) Print the page to invoke the page break css
5) Note that with the patch each notice is on it's own page, without the
   patch all the notices run one after the other on the same page.
Comment 3 Andrew Fuerste-Henry 2024-11-25 16:30:41 UTC
Created attachment 174981 [details] [review]
Bug 38070: Revert class change so notices print one per page

This patch reverses the bootstrap 5 find and replace for the 'message'
class.

In this file the message class didn't refer to the bootstrap themeing
but rather is used for applying `page-break-after: always` to these
elements.

Test plan
1) Line up some print notices
2) Run gather_print_notices.pl with html file output
3) Open the output file
4) Print the page to invoke the page break css
5) Note that with the patch each notice is on it's own page, without the
   patch all the notices run one after the other on the same page.

Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>