Bug 38076

Summary: Librarians with only fast add permission can no longer edit or create fast add records
Product: Koha Reporter: Kyle M Hall (khall) <kyle>
Component: CatalogingAssignee: Kyle M Hall (khall) <kyle>
Status: RESOLVED FIXED QA Contact: Tomás Cohen Arazi (tcohen) <tomascohen>
Severity: critical    
Priority: P5 - low CC: blawlor, caroline.cyr-la-rose, chughesman, fridolin.somers, george, jonathan.druart, lauren_denny, lucas, m.de.rooy, mnero, mspinney, tomascohen
Version: unspecifiedKeywords: regression
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.05
Circulation function:
Bug Depends on: 37947    
Bug Blocks: 38094, 38211    
Attachments: Bug 38076: Fix inability of fast catalogers to add/edit FA framework records
Bug 38076: Fix inability of fast catalogers to add/edit FA framework records
Bug 38076: Fix inability of fast catalogers to add/edit FA framework records
Bug 38076: (QA follow-up): Make permission edit_catalogue imply fast_cataloging

Description Kyle M Hall (khall) 2024-10-03 14:13:36 UTC
If a librarian does not have the editcatalogue permission, but does have the fast_cataloging permission, they should be able to add and edit fast cataloging records. Instead they are presented with a login screen and the message that they do not have sufficient permissions.
Comment 1 Kyle M Hall (khall) 2024-10-03 14:18:02 UTC
Created attachment 172341 [details] [review]
Bug 38076: Fix inability of fast catalogers to add/edit FA framework records

If a librarian does not have the editcatalogue permission, but does have the fast_cataloging permission, they should be able to add and edit fast cataloging records. Instead they are presented with a login screen and the message that they do not have sufficient permissions.

Test Plan:
1) Create a librarian with only fast add cataloging permissions
2) Attempt to create a fast cat item from the circ menu
3) Note the login screen and error
4) Apply this patch
5) Restart all the things!
6) Try again, you can now create FA records!
Comment 2 Brendan Lawlor 2024-10-03 16:03:52 UTC
Created attachment 172363 [details] [review]
Bug 38076: Fix inability of fast catalogers to add/edit FA framework records

If a librarian does not have the editcatalogue permission, but does have the fast_cataloging permission, they should be able to add and edit fast cataloging records. Instead they are presented with a login screen and the message that they do not have sufficient permissions.

Test Plan:
1) Create a librarian with only fast add cataloging permissions
2) Attempt to create a fast cat item from the circ menu
3) Note the login screen and error
4) Apply this patch
5) Restart all the things!
6) Try again, you can now create FA records!

Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Comment 3 Kyle M Hall (khall) 2024-10-03 16:11:37 UTC
Thank for the SO Brendan!
Comment 4 Brendan Lawlor 2024-10-03 16:15:53 UTC
Thanks for the quick patch! This is really important for our consortium the way we do centralized cataloging.
Comment 5 Tomás Cohen Arazi (tcohen) 2024-10-03 18:50:47 UTC
Created attachment 172368 [details] [review]
Bug 38076: Fix inability of fast catalogers to add/edit FA framework records

If a librarian does not have the editcatalogue permission, but does have the fast_cataloging permission, they should be able to add and edit fast cataloging records. Instead they are presented with a login screen and the message that they do not have sufficient permissions.

Test Plan:
1) Create a librarian with only fast add cataloging permissions
2) Attempt to create a fast cat item from the circ menu
3) Note the login screen and error
4) Apply this patch
5) Restart all the things!
6) Try again, you can now create FA records!

Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 6 Kyle M Hall (khall) 2024-10-04 14:59:14 UTC
Created attachment 172411 [details] [review]
Bug 38076: (QA follow-up): Make permission edit_catalogue imply fast_cataloging

Any librarian with the edit_catalogue sub-permission should also be able
to edit fast catalog records. If that was not true, a cataloger could
not convert fast adds into full records.
Comment 7 Katrin Fischer 2024-10-11 09:16:00 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 8 Jonathan Druart 2024-10-21 09:51:28 UTC
Well ok, but then you are moving up $op and introduces another bug.

See bug 38211
Comment 9 Lucas Gass (lukeg) 2024-10-23 22:45:45 UTC
Backported to 24.05.x for upcoming 24.05.05
Comment 10 Fridolin Somers 2024-10-25 13:56:10 UTC
Depends on Bug 37947 not in 23.11.x
Comment 11 Caroline Cyr La Rose 2025-04-18 19:33:00 UTC
Bug fix, nothing to add/edit in the manual.