Bug 38077

Summary: Minor spacing issue in self checkout login page
Product: Koha Reporter: Caroline Cyr La Rose <caroline.cyr-la-rose>
Component: OPACAssignee: Owen Leonard <oleonard>
Status: Pushed to main --- QA Contact: Katrin Fischer <katrin.fischer>
Severity: trivial    
Priority: P5 - low CC: david
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
This fixes a minor spacing issue on the self checkout login page. The login form is now arranged vertically and includes more padding.
Version(s) released in:
25.05.00
Circulation function:
Attachments: Bug 38077: Fix minor spacing issue in self checkout login page
Bug 38077: Fix minor spacing issue in self checkout login page

Description Caroline Cyr La Rose 2024-10-03 14:36:29 UTC
When accessing the sco-main.pl page, there is no space between the password field and the login button. A little padding there would look better.

To get there:

If using KTD, 

1. Go to http://kohadev.mydnsname.org:8080/cgi-bin/koha/sco/sco-main.pl

If not using KTD,

1. Create a patron with the self_checkout_module permission
2. In system preferences,
   - set WebBasedSelfCheck to Enable
   - set AutoSelfCheckAllowed to Allow
   - enter the login of the patron created in step 1 in AutoSelfCheckID
   - enter the password of the patron created in step 1 in AutoSelfCheckPass
3. Go to opac/cgi-bin/koha/sco/sco-main.pl
Comment 1 Caroline Cyr La Rose 2024-10-03 14:37:20 UTC
Same thing if SelfCheckoutByLogin is set to cardnumber.
Comment 2 Owen Leonard 2024-12-16 19:40:48 UTC
Created attachment 175576 [details] [review]
Bug 38077: Fix minor spacing issue in self checkout login page

This patch adjusts the markup and CSS of the self checkout login screen
so that form layout is consistent and readable. I have adjusted the
template conditional so that it re-uses more form elements like
<legend>.

To test, apply the patch and enable WebBasedSelfCheck if necessary.

- Set the SelfCheckoutByLogin system preference to 'cardnumber'
- Go to the self-checkout page (/cgi-bin/koha/sco/sco-main.pl)
  - The login form should be labeled "Log in to your account" followed
    by the label, form field, and submit button arranged vertically.
- Set the SelfCheckoutByLogin preference to "username and password"
- Reload the self-checkout page. The form should look the same with the
  addition of the password field.

Sponsored-by: Athens County Public Libraries
Comment 3 David Nind 2024-12-16 23:32:17 UTC
Created attachment 175581 [details] [review]
Bug 38077: Fix minor spacing issue in self checkout login page

This patch adjusts the markup and CSS of the self checkout login screen
so that form layout is consistent and readable. I have adjusted the
template conditional so that it re-uses more form elements like
<legend>.

To test, apply the patch and enable WebBasedSelfCheck if necessary.

- Set the SelfCheckoutByLogin system preference to 'cardnumber'
- Go to the self-checkout page (/cgi-bin/koha/sco/sco-main.pl)
  - The login form should be labeled "Log in to your account" followed
    by the label, form field, and submit button arranged vertically.
- Set the SelfCheckoutByLogin preference to "username and password"
- Reload the self-checkout page. The form should look the same with the
  addition of the password field.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2024-12-16 23:34:48 UTC
Testing notes (using KTD):

1. After applying the patch, run yarn build
Comment 5 Katrin Fischer 2024-12-27 15:23:07 UTC
QA by RM
Comment 6 Katrin Fischer 2024-12-27 16:36:23 UTC
Pushed for 25.05!

Well done everyone, thank you!