| Summary: | Sorting options for holdings table are incorrect | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | OPAC | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | Pushed to oldstable --- | QA Contact: | Laura Escamilla <Laura.escamilla> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | david, fridolin.somers, gmcharlt, jonathan.druart, Laura.escamilla, michaela.sieber |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This fixes the default sort order for the OPAC holdings table, so that the default table sorting setting is used. Previously, it was not correctly using this setting (for example, setting the shelving location as the default sort order did not work).
|
Version(s) released in: |
25.11.00,25.05.06,24.11.11
|
| Circulation function: | |||
| Bug Depends on: | 14919 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 38080: Fix order of columns in opac's holdings tables
Bug 38080: Fix order of columns in opac's holdings tables Bug 38080: Fix order of columns in opac's holdings tables |
||
|
Description
Nick Clemens (kidclamp)
2024-10-03 17:25:42 UTC
I don't recreate, can you provide more details please? http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=4 Click "Collection" => http://localhost:8081/api/v1/biblios/4/items?&_page=1&_per_page=20&_match=contains&_order_by=%2Bme.collection_code I do recreate the problem at the OPAC Caused by commit 4fa34acc414a1580019df62c28bb39bb6d9f3e85 Bug 14919: Add holds history for patron Created attachment 188142 [details] [review] Bug 38080: Fix order of columns in opac's holdings tables The order of the columns in the yaml file must match the order of the columns in the template file. Test plan: Confirm that, with bug 30633 applied, you can pick "shelving location" as the default sort order and that the items are correctly sorted by shelving location. This bug has certainly been opened for the staff. In the OPAC the problem shouldn't be visible before bug 30633. Created attachment 188451 [details] [review] Bug 38080: Fix order of columns in opac's holdings tables The order of the columns in the yaml file must match the order of the columns in the template file. Test plan: Confirm that, with bug 30633 applied, you can pick "shelving location" as the default sort order and that the items are correctly sorted by shelving location. Signed-off-by: David Nind <david@davidnind.com> I hope I have tested this correctly. Testing notes (using KTD on main, bug 30633 is already included in main) 1. Replicate the issue: 1.1 Find a record with multiple items. I used record 255 - Perl template toolkit, with four items. 1.2 Change the shelving locations for each item, so that each item is different. I edited items so that the shelving locations were General stacks, New materials shelf, Fiction, Children's area. 1.3 For the OPAC holdings table setting (Administration > Other > Table settings > OPAC > biblio-detail > holdingst), set the default sort order to shelving location (item_shelving_location). 1.4 Set OpacLocationOnDetail = on a separate column. 1.5 Open the record details page in the OPAC. 1.6. Note the collection code column is used to sort the holdings table (the Collection column has the ascending arrow in dark green highlighted). 1.7 Note that the shelving location was not used as the default sorting order. 2. Apply the patch. 3. Reset everything (reset_all). 4. Repeat steps 1.1 to 1.5. 5. Note that now the shelving location is used to sort the items (the shelving location column has the ascending arrow in dark green highlighted), and these are in ascending alphabetical order. Created attachment 188661 [details] [review] Bug 38080: Fix order of columns in opac's holdings tables The order of the columns in the yaml file must match the order of the columns in the template file. Test plan: Confirm that, with bug 30633 applied, you can pick "shelving location" as the default sort order and that the items are correctly sorted by shelving location. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Nice work everyone! Pushed to main for 25.11 Nice work everyone! Pushed to 25.05.x Pushed to 24.11.x for 24.11.11 |