Bug 38094

Summary: Librarians with only fast add permission can no longer edit existing fast add records
Product: Koha Reporter: Kyle M Hall (khall) <kyle>
Component: CatalogingAssignee: Kyle M Hall (khall) <kyle>
Status: Needs documenting --- QA Contact: Tomás Cohen Arazi (tcohen) <tomascohen>
Severity: critical    
Priority: P5 - low CC: blawlor, chughesman, fridolin.somers, kyle, lucas, m.de.rooy, mnero, mspinney, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.05
Circulation function:
Bug Depends on: 38076    
Bug Blocks:    
Attachments: Bug 38094 - Librarians with only fast add permission can no longer edit fast add records
Bug 38094: Allow librarians with fast add permissions to edit existing fast add records
Bug 38094: Allow librarians with fast add permissions to edit existing fast add records
Bug 38094: Regression tests
Bug 38094: Allow librarians with fast add permissions to edit existing fast add records
Bug 38094: (follow-up) edit_catalogue implies fast_cataloguing
Bug 38094: Regression tests
Bug 38094: Allow librarians with fast add permissions to edit existing fast add records
Bug 38094: (follow-up) edit_catalogue implies fast_cataloguing

Description Kyle M Hall (khall) 2024-10-04 14:09:42 UTC
The ability to create fast add records was fixed on bug 38076, but they still cannot be edited after they are saved.
Comment 1 Kyle M Hall (khall) 2024-10-04 14:12:04 UTC
Created attachment 172402 [details] [review]
Bug 38094 - Librarians with only fast add permission can no longer edit fast add records

The ability to create fast add records was fixed on bug 38076, but they still cannot be edited after they are saved.

Test Plan:
1) Create a librarian with only fast add cataloging permissions
2) Create a fast add record, save it
3) Attempt to edit that record, you cannot!
4) Apply this patch
5) Restart all the things!
6) Attempt to edit that record, you can!
7) Attempt to edit a non-FA record, you cannot!
Comment 2 Kyle M Hall (khall) 2024-10-04 14:16:49 UTC
Created attachment 172403 [details] [review]
Bug 38094: Allow librarians with fast add permissions to edit existing fast add records

The ability to create fast add records was fixed on bug 38076, but they still cannot be edited after they are saved.

Test Plan:
1) Create a librarian with only fast add cataloging permissions
2) Create a fast add record, save it
3) Attempt to edit that record, you cannot!
4) Apply this patch
5) Restart all the things!
6) Attempt to edit that record, you can!
7) Attempt to edit a non-FA record, you cannot!
Comment 3 Brendan Lawlor 2024-10-04 14:35:38 UTC
Created attachment 172404 [details] [review]
Bug 38094: Allow librarians with fast add permissions to edit existing fast add records

The ability to create fast add records was fixed on bug 38076, but they still cannot be edited after they are saved.

Test Plan:
1) Create a librarian with only fast add cataloging permissions
2) Create a fast add record, save it
3) Attempt to edit that record, you cannot!
4) Apply this patch
5) Restart all the things!
6) Attempt to edit that record, you can!
7) Attempt to edit a non-FA record, you cannot!

Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Comment 4 Tomás Cohen Arazi (tcohen) 2024-10-04 14:42:52 UTC Comment hidden (obsolete)
Comment 5 Tomás Cohen Arazi (tcohen) 2024-10-04 14:42:55 UTC Comment hidden (obsolete)
Comment 6 Tomás Cohen Arazi (tcohen) 2024-10-04 14:42:58 UTC Comment hidden (obsolete)
Comment 7 Tomás Cohen Arazi (tcohen) 2024-10-04 14:44:13 UTC
Created attachment 172408 [details] [review]
Bug 38094: Regression tests

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 8 Tomás Cohen Arazi (tcohen) 2024-10-04 14:44:15 UTC
Created attachment 172409 [details] [review]
Bug 38094: Allow librarians with fast add permissions to edit existing fast add records

The ability to create fast add records was fixed on bug 38076, but they still cannot be edited after they are saved.

Test Plan:
1) Create a librarian with only fast add cataloging permissions
2) Create a fast add record, save it
3) Attempt to edit that record, you cannot!
4) Apply this patch
5) Restart all the things!
6) Attempt to edit that record, you can!
7) Attempt to edit a non-FA record, you cannot!

Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 9 Tomás Cohen Arazi (tcohen) 2024-10-04 14:44:18 UTC
Created attachment 172410 [details] [review]
Bug 38094: (follow-up) edit_catalogue implies fast_cataloguing

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 10 Katrin Fischer 2024-10-11 09:16:08 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 11 Lucas Gass (lukeg) 2024-10-23 22:48:23 UTC
Backported to 24.05.x for upcoming 24.05.05
Comment 12 Fridolin Somers 2024-10-25 13:56:47 UTC
Depends on Bug 38076 not in 23.11.x