Summary: | Add class to "Item was not checked out" message in checkin table | ||
---|---|---|---|
Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
Component: | Circulation | Assignee: | Andrew Fuerste-Henry <andrew> |
Status: | RESOLVED FIXED | QA Contact: | Lucas Gass (lukeg) <lucas> |
Severity: | minor | ||
Priority: | P5 - low | CC: | ephetteplace, fridolin.somers, gmcharlt, jesse, kyle.m.hall, lucas, martin.renvoize, phil |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.11.00,24.05.06,23.11.11
|
|
Circulation function: | |||
Attachments: |
Bug 38097: Add class to not_retuned message
Bug 38097: Add class to not_retuned message Bug 38097: Add class to not_retuned message |
Description
Andrew Fuerste-Henry
2024-10-04 16:31:20 UTC
Created attachment 172419 [details] [review] Bug 38097: Add class to not_retuned message To test: 1: Enable ShowAllCheckins 2: Check in an item that was not checked out 3: Find "Item was not checked in" message in checkin table, confirm its only class is "problem" 4: apply patch, restart_all 5: repeat 2 6: confirm "Item was not checked in" now has the class "not_returned" Created attachment 172425 [details] [review] Bug 38097: Add class to not_retuned message Bug 38097: Add class to not_retuned message To test: 1: Enable ShowAllCheckins 2: Check in an item that was not checked out 3: Find "Item was not checked in" message in checkin table, confirm its only class is "problem" 4: apply patch, restart_all 5: repeat 2 6: confirm "Item was not checked in" now has the class "not_returned" Signed-off-by: Eric Phetteplace <phette23@gmail.com> Trivial fix, looks good. Always nice to have more ids/classes for easier customization. Thanks, Andrew. Created attachment 172496 [details] [review] Bug 38097: Add class to not_retuned message To test: 1: Enable ShowAllCheckins 2: Check in an item that was not checked out 3: Find "Item was not checked in" message in checkin table, confirm its only class is "problem" 4: apply patch, restart_all 5: repeat 2 6: confirm "Item was not checked in" now has the class "not_returned" Signed-off-by: Eric Phetteplace <phette23@gmail.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.06 <span class="problem not_returned">Item was not checked in</span> Maybe we could change class "problem" with something like "warning" and style it yellow. For another bug report ;) Pushed to 23.11.x for 23.11.11 Not pushed to LTS(22.11.x). Marked Resolved. If you feel this should be in LTS(22.11.x) please reply with your reason. |