Bug 38097

Summary: Add class to "Item was not checked out" message in checkin table
Product: Koha Reporter: Andrew Fuerste-Henry <andrew>
Component: CirculationAssignee: Andrew Fuerste-Henry <andrew>
Status: RESOLVED FIXED QA Contact: Lucas Gass (lukeg) <lucas>
Severity: minor    
Priority: P5 - low CC: ephetteplace, fridolin.somers, gmcharlt, jesse, kyle.m.hall, lucas, martin.renvoize, phil
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.06,23.11.11
Circulation function:
Attachments: Bug 38097: Add class to not_retuned message
Bug 38097: Add class to not_retuned message
Bug 38097: Add class to not_retuned message

Description Andrew Fuerste-Henry 2024-10-04 16:31:20 UTC
When ShowAllCheckins is enabled, items that were entered into the "check-in" field without actually being checked out to a patron, Koha lists the item in the checkins table with a red "Item was not checked in" message. This message is not to everyone's liking and lacks a unique class.
Comment 1 Andrew Fuerste-Henry 2024-10-04 16:34:14 UTC
Created attachment 172419 [details] [review]
Bug 38097: Add class to not_retuned message

To test:
1: Enable ShowAllCheckins
2: Check in an item that was not checked out
3: Find "Item was not checked in" message in checkin table, confirm its only class is "problem"
4: apply patch, restart_all
5: repeat 2
6: confirm "Item was not checked in" now has the class "not_returned"
Comment 2 Eric Phetteplace 2024-10-04 17:12:05 UTC
Created attachment 172425 [details] [review]
Bug 38097: Add class to not_retuned message

Bug 38097: Add class to not_retuned message

To test:
1: Enable ShowAllCheckins
2: Check in an item that was not checked out
3: Find "Item was not checked in" message in checkin table, confirm its only class is "problem"
4: apply patch, restart_all
5: repeat 2
6: confirm "Item was not checked in" now has the class "not_returned"

Signed-off-by: Eric Phetteplace <phette23@gmail.com>
Comment 3 Lucas Gass (lukeg) 2024-10-07 17:19:10 UTC
Trivial fix, looks good. Always nice to have more ids/classes for easier customization. Thanks, Andrew.
Comment 4 Lucas Gass (lukeg) 2024-10-07 17:19:35 UTC
Created attachment 172496 [details] [review]
Bug 38097: Add class to not_retuned message

To test:
1: Enable ShowAllCheckins
2: Check in an item that was not checked out
3: Find "Item was not checked in" message in checkin table, confirm its only class is "problem"
4: apply patch, restart_all
5: repeat 2
6: confirm "Item was not checked in" now has the class "not_returned"

Signed-off-by: Eric Phetteplace <phette23@gmail.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 5 Katrin Fischer 2024-10-11 10:28:00 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 6 Lucas Gass (lukeg) 2024-11-18 23:21:37 UTC
Backported to 24.05.x for upcoming 24.05.06
Comment 7 Fridolin Somers 2024-12-11 15:22:05 UTC
<span class="problem not_returned">Item was not checked in</span>


Maybe we could change class "problem" with something like "warning" and style it yellow.

For another bug report ;)
Comment 8 Fridolin Somers 2024-12-11 15:22:38 UTC
Pushed to 23.11.x for 23.11.11
Comment 9 Jesse Maseto 2025-02-03 17:00:33 UTC
Not pushed to LTS(22.11.x). Marked Resolved.

If you feel this should be in LTS(22.11.x) please reply with your reason.