When ShowAllCheckins is enabled, items that were entered into the "check-in" field without actually being checked out to a patron, Koha lists the item in the checkins table with a red "Item was not checked in" message. This message is not to everyone's liking and lacks a unique class.
Created attachment 172419 [details] [review] Bug 38097: Add class to not_retuned message To test: 1: Enable ShowAllCheckins 2: Check in an item that was not checked out 3: Find "Item was not checked in" message in checkin table, confirm its only class is "problem" 4: apply patch, restart_all 5: repeat 2 6: confirm "Item was not checked in" now has the class "not_returned"
Created attachment 172425 [details] [review] Bug 38097: Add class to not_retuned message Bug 38097: Add class to not_retuned message To test: 1: Enable ShowAllCheckins 2: Check in an item that was not checked out 3: Find "Item was not checked in" message in checkin table, confirm its only class is "problem" 4: apply patch, restart_all 5: repeat 2 6: confirm "Item was not checked in" now has the class "not_returned" Signed-off-by: Eric Phetteplace <phette23@gmail.com>
Trivial fix, looks good. Always nice to have more ids/classes for easier customization. Thanks, Andrew.
Created attachment 172496 [details] [review] Bug 38097: Add class to not_retuned message To test: 1: Enable ShowAllCheckins 2: Check in an item that was not checked out 3: Find "Item was not checked in" message in checkin table, confirm its only class is "problem" 4: apply patch, restart_all 5: repeat 2 6: confirm "Item was not checked in" now has the class "not_returned" Signed-off-by: Eric Phetteplace <phette23@gmail.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.x for upcoming 24.05.06
<span class="problem not_returned">Item was not checked in</span> Maybe we could change class "problem" with something like "warning" and style it yellow. For another bug report ;)
Pushed to 23.11.x for 23.11.11