Bug 38125

Summary: Setting patron reading privacy to "never" will immediately delete all reading history without warning
Product: Koha Reporter: Kyle M Hall (khall) <kyle>
Component: OPACAssignee: Kyle M Hall (khall) <kyle>
Status: RESOLVED FIXED QA Contact: Martin Renvoize (ashimema) <martin.renvoize>
Severity: trivial    
Priority: P5 - low CC: lucas, martin.renvoize
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:
Attachments: Bug 38125: Add a warning if privacy pulldown is changed to "never"
Bug 38125: Add a warning if privacy pulldown is changed to "never"
Bug 38125: Add a warning if privacy pulldown is changed to "never"

Description Kyle M Hall (khall) 2024-10-08 16:59:31 UTC
It is possible to interpret the language on opac-privacy.pl as only acting on future checkins and not current historical checkouts. We should add clarifying text to that page.
Comment 1 Kyle M Hall (khall) 2024-10-08 17:40:55 UTC
Created attachment 172542 [details] [review]
Bug 38125: Add a warning if privacy pulldown is changed to "never"

It is possible to interpret the language on opac-privacy.pl as only acting on future checkins and not current historical checkouts. We should add clarifying text to that page

Test plan:
1) Apply this patch
2) Enable opac privacy
3) Change pulldown to "never"
4) Note the warning message appears
Comment 2 Owen Leonard 2024-10-14 15:16:23 UTC
Created attachment 172737 [details] [review]
Bug 38125: Add a warning if privacy pulldown is changed to "never"

It is possible to interpret the language on opac-privacy.pl as only
acting on future checkins and not current historical checkouts. We
should add clarifying text to that page

Test plan:
1) Apply this patch
2) Enable opac privacy
3) Change pulldown to "never"
4) Note the warning message appears

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Martin Renvoize (ashimema) 2024-10-28 14:48:52 UTC
Created attachment 173545 [details] [review]
Bug 38125: Add a warning if privacy pulldown is changed to "never"

It is possible to interpret the language on opac-privacy.pl as only
acting on future checkins and not current historical checkouts. We
should add clarifying text to that page

Test plan:
1) Apply this patch
2) Enable opac privacy
3) Change pulldown to "never"
4) Note the warning message appears

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Katrin Fischer 2024-10-29 15:18:09 UTC
Pushed for 24.11!

Well done everyone, thank you!