Bug 38125 - Setting patron reading privacy to "never" will immediately delete all reading history without warning
Summary: Setting patron reading privacy to "never" will immediately delete all reading...
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low trivial
Assignee: Kyle M Hall (khall)
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-08 16:59 UTC by Kyle M Hall (khall)
Modified: 2024-10-29 15:18 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 38125: Add a warning if privacy pulldown is changed to "never" (2.33 KB, patch)
2024-10-08 17:40 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 38125: Add a warning if privacy pulldown is changed to "never" (2.36 KB, patch)
2024-10-14 15:16 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38125: Add a warning if privacy pulldown is changed to "never" (2.43 KB, patch)
2024-10-28 14:48 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall (khall) 2024-10-08 16:59:31 UTC
It is possible to interpret the language on opac-privacy.pl as only acting on future checkins and not current historical checkouts. We should add clarifying text to that page.
Comment 1 Kyle M Hall (khall) 2024-10-08 17:40:55 UTC
Created attachment 172542 [details] [review]
Bug 38125: Add a warning if privacy pulldown is changed to "never"

It is possible to interpret the language on opac-privacy.pl as only acting on future checkins and not current historical checkouts. We should add clarifying text to that page

Test plan:
1) Apply this patch
2) Enable opac privacy
3) Change pulldown to "never"
4) Note the warning message appears
Comment 2 Owen Leonard 2024-10-14 15:16:23 UTC
Created attachment 172737 [details] [review]
Bug 38125: Add a warning if privacy pulldown is changed to "never"

It is possible to interpret the language on opac-privacy.pl as only
acting on future checkins and not current historical checkouts. We
should add clarifying text to that page

Test plan:
1) Apply this patch
2) Enable opac privacy
3) Change pulldown to "never"
4) Note the warning message appears

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Martin Renvoize (ashimema) 2024-10-28 14:48:52 UTC
Created attachment 173545 [details] [review]
Bug 38125: Add a warning if privacy pulldown is changed to "never"

It is possible to interpret the language on opac-privacy.pl as only
acting on future checkins and not current historical checkouts. We
should add clarifying text to that page

Test plan:
1) Apply this patch
2) Enable opac privacy
3) Change pulldown to "never"
4) Note the warning message appears

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Katrin Fischer 2024-10-29 15:18:09 UTC
Pushed for 24.11!

Well done everyone, thank you!