Bug 38158

Summary: Typo in inventory 'Items has no "not for loan" status'
Product: Koha Reporter: Caroline Cyr La Rose <caroline.cyr-la-rose>
Component: CatalogingAssignee: Caroline Cyr La Rose <caroline.cyr-la-rose>
Status: RESOLVED FIXED QA Contact: Emily Lamancusa (emlam) <emily.lamancusa>
Severity: trivial    
Priority: P5 - low CC: emily.lamancusa, fridolin.somers, jesse, lucas, m.de.rooy, sam.sowanick
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.06,23.11.11
Circulation function:
Attachments: Bug 38158: Typo in inventory 'Items has no "not for loan" status'
Bug 38158: Typo in inventory 'Items has no "not for loan" status'
Bug 38158: Typo in inventory 'Items has no "not for loan" status'

Description Caroline Cyr La Rose 2024-10-11 19:54:56 UTC
When using the inventory tool to check not for loan items, one of the problem sentences has a typo.

To get there:
1. Go to Cataloging > Inventory
2. Enter a barcode for an item that has items.notforloan = 0 in the "Or scan items one by one" text box
3. Check all the boxes EXCEPT "For loan" under "Optional filters for inventory list or comparing barcodes" > "items.notforloan" 
4. Click "Submit"
   --> In the "Problems" column, it says "Items has no "not for loan" status"

"Items" should be singular in this case.
Comment 1 Caroline Cyr La Rose 2024-10-11 19:59:25 UTC
Created attachment 172703 [details] [review]
Bug 38158: Typo in inventory 'Items has no "not for loan" status'

This patch corrects a typo in the inventory tool when an inventory
is done against not for loan items and an item has no not for loan
status.

To test:
1. Go to Cataloging > Inventory
2. Enter a barcode for an item that has items.notforloan = 0 in the "Or scan items one by one" text box
3. Check all the boxes EXCEPT "For loan" under "Optional filters for inventory list or comparing barcodes" > "items.notforloan"
4. Click "Submit"
   --> In the "Problems" column, it says "Items has no "not for loan" status"
5. Apply patch
6. Reload the page
   --> In the "Problems" column, "Item" should now be singular
Comment 2 Biblibre Sandboxes 2024-10-15 20:10:49 UTC
Created attachment 172795 [details] [review]
Bug 38158: Typo in inventory 'Items has no "not for loan" status'

This patch corrects a typo in the inventory tool when an inventory
is done against not for loan items and an item has no not for loan
status.

To test:
1. Go to Cataloging > Inventory
2. Enter a barcode for an item that has items.notforloan = 0 in the "Or scan items one by one" text box
3. Check all the boxes EXCEPT "For loan" under "Optional filters for inventory list or comparing barcodes" > "items.notforloan"
4. Click "Submit"
   --> In the "Problems" column, it says "Items has no "not for loan" status"
5. Apply patch
6. Reload the page
   --> In the "Problems" column, "Item" should now be singular

Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
Comment 3 Emily Lamancusa (emlam) 2024-10-28 17:11:34 UTC
Created attachment 173572 [details] [review]
Bug 38158: Typo in inventory 'Items has no "not for loan" status'

This patch corrects a typo in the inventory tool when an inventory
is done against not for loan items and an item has no not for loan
status.

To test:
1. Go to Cataloging > Inventory
2. Enter a barcode for an item that has items.notforloan = 0 in the "Or scan items one by one" text box
3. Check all the boxes EXCEPT "For loan" under "Optional filters for inventory list or comparing barcodes" > "items.notforloan"
4. Click "Submit"
   --> In the "Problems" column, it says "Items has no "not for loan" status"
5. Apply patch
6. Reload the page
   --> In the "Problems" column, "Item" should now be singular

Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 4 Katrin Fischer 2024-10-30 06:48:46 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 5 Lucas Gass (lukeg) 2024-12-05 19:18:36 UTC
Backported to 24.05.x for upcoming 24.05.06
Comment 6 Fridolin Somers 2024-12-18 09:30:19 UTC
Pushed to 23.11.x for 23.11.11
Comment 7 Jesse Maseto 2025-02-03 16:36:08 UTC
Not pushed to LTS. Marked Resolved.

If you feel this should be in LTS please reply with your reason.