Bug 38158 - Typo in inventory 'Items has no "not for loan" status'
Summary: Typo in inventory 'Items has no "not for loan" status'
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Caroline Cyr La Rose
QA Contact: Emily Lamancusa (emlam)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-11 19:54 UTC by Caroline Cyr La Rose
Modified: 2024-10-30 06:52 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 38158: Typo in inventory 'Items has no "not for loan" status' (2.02 KB, patch)
2024-10-11 19:59 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 38158: Typo in inventory 'Items has no "not for loan" status' (2.09 KB, patch)
2024-10-15 20:10 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 38158: Typo in inventory 'Items has no "not for loan" status' (2.16 KB, patch)
2024-10-28 17:11 UTC, Emily Lamancusa (emlam)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2024-10-11 19:54:56 UTC
When using the inventory tool to check not for loan items, one of the problem sentences has a typo.

To get there:
1. Go to Cataloging > Inventory
2. Enter a barcode for an item that has items.notforloan = 0 in the "Or scan items one by one" text box
3. Check all the boxes EXCEPT "For loan" under "Optional filters for inventory list or comparing barcodes" > "items.notforloan" 
4. Click "Submit"
   --> In the "Problems" column, it says "Items has no "not for loan" status"

"Items" should be singular in this case.
Comment 1 Caroline Cyr La Rose 2024-10-11 19:59:25 UTC
Created attachment 172703 [details] [review]
Bug 38158: Typo in inventory 'Items has no "not for loan" status'

This patch corrects a typo in the inventory tool when an inventory
is done against not for loan items and an item has no not for loan
status.

To test:
1. Go to Cataloging > Inventory
2. Enter a barcode for an item that has items.notforloan = 0 in the "Or scan items one by one" text box
3. Check all the boxes EXCEPT "For loan" under "Optional filters for inventory list or comparing barcodes" > "items.notforloan"
4. Click "Submit"
   --> In the "Problems" column, it says "Items has no "not for loan" status"
5. Apply patch
6. Reload the page
   --> In the "Problems" column, "Item" should now be singular
Comment 2 Biblibre Sandboxes 2024-10-15 20:10:49 UTC
Created attachment 172795 [details] [review]
Bug 38158: Typo in inventory 'Items has no "not for loan" status'

This patch corrects a typo in the inventory tool when an inventory
is done against not for loan items and an item has no not for loan
status.

To test:
1. Go to Cataloging > Inventory
2. Enter a barcode for an item that has items.notforloan = 0 in the "Or scan items one by one" text box
3. Check all the boxes EXCEPT "For loan" under "Optional filters for inventory list or comparing barcodes" > "items.notforloan"
4. Click "Submit"
   --> In the "Problems" column, it says "Items has no "not for loan" status"
5. Apply patch
6. Reload the page
   --> In the "Problems" column, "Item" should now be singular

Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
Comment 3 Emily Lamancusa (emlam) 2024-10-28 17:11:34 UTC
Created attachment 173572 [details] [review]
Bug 38158: Typo in inventory 'Items has no "not for loan" status'

This patch corrects a typo in the inventory tool when an inventory
is done against not for loan items and an item has no not for loan
status.

To test:
1. Go to Cataloging > Inventory
2. Enter a barcode for an item that has items.notforloan = 0 in the "Or scan items one by one" text box
3. Check all the boxes EXCEPT "For loan" under "Optional filters for inventory list or comparing barcodes" > "items.notforloan"
4. Click "Submit"
   --> In the "Problems" column, it says "Items has no "not for loan" status"
5. Apply patch
6. Reload the page
   --> In the "Problems" column, "Item" should now be singular

Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 4 Katrin Fischer 2024-10-30 06:48:46 UTC
Pushed for 24.11!

Well done everyone, thank you!