Summary: | State not restored correctly on suggestion tables | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Staff interface | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | RESOLVED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, lucas, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.11.00
|
|
Circulation function: | |||
Bug Depends on: | 33426, 38183 | ||
Bug Blocks: | 33484 | ||
Attachments: |
Bug 38192: Fix restoration of table state for suggestion tables
Bug 38192: Fix restoration of table state for suggestion tables Bug 38192: Fix restoration of table state for suggestion tables Bug 38192: Fix restoration of table state for suggestion tables |
Description
Jonathan Druart
2024-10-17 09:52:28 UTC
Created attachment 172862 [details] [review] Bug 38192: Fix restoration of table state for suggestion tables There is one table per tab, the id of the table is table_N. Say you have: Pending (#table_1), Accepted (#table_2), Rejected (#table_3) The state will be stored in localStorage with the following key: DataTables_table_1_/cgi-bin/koha/suggestion/suggestion.pl DataTables_table_2_/cgi-bin/koha/suggestion/suggestion.pl DataTables_table_3_/cgi-bin/koha/suggestion/suggestion.pl If you move all the suggestions from Accepted to Rejected, a shift will give: Pending (#table_1), Rejected (#table_2) And the previous state from the "Accepted" tab will be used for "Rejected" Test plan: Confirm the above, have several tabs then remove one by moving the all suggestions to an other tab. Test the other features on the edit and list views: change status, update manager, etc. Created attachment 172868 [details] [review] Bug 38192: Fix restoration of table state for suggestion tables There is one table per tab, the id of the table is table_N. Say you have: Pending (#table_1), Accepted (#table_2), Rejected (#table_3) The state will be stored in localStorage with the following key: DataTables_table_1_/cgi-bin/koha/suggestion/suggestion.pl DataTables_table_2_/cgi-bin/koha/suggestion/suggestion.pl DataTables_table_3_/cgi-bin/koha/suggestion/suggestion.pl If you move all the suggestions from Accepted to Rejected, a shift will give: Pending (#table_1), Rejected (#table_2) And the previous state from the "Accepted" tab will be used for "Rejected" Test plan: Confirm the above, have several tabs then remove one by moving the all suggestions to an other tab. Test the other features on the edit and list views: change status, update manager, etc. Created attachment 172879 [details] [review] Bug 38192: Fix restoration of table state for suggestion tables There is one table per tab, the id of the table is table_N. Say you have: Pending (#table_1), Accepted (#table_2), Rejected (#table_3) The state will be stored in localStorage with the following key: DataTables_table_1_/cgi-bin/koha/suggestion/suggestion.pl DataTables_table_2_/cgi-bin/koha/suggestion/suggestion.pl DataTables_table_3_/cgi-bin/koha/suggestion/suggestion.pl If you move all the suggestions from Accepted to Rejected, a shift will give: Pending (#table_1), Rejected (#table_2) And the previous state from the "Accepted" tab will be used for "Rejected" Test plan: Confirm the above, have several tabs then remove one by moving the all suggestions to an other tab. Test the other features on the edit and list views: change status, update manager, etc. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 173352 [details] [review] Bug 38192: Fix restoration of table state for suggestion tables There is one table per tab, the id of the table is table_N. Say you have: Pending (#table_1), Accepted (#table_2), Rejected (#table_3) The state will be stored in localStorage with the following key: DataTables_table_1_/cgi-bin/koha/suggestion/suggestion.pl DataTables_table_2_/cgi-bin/koha/suggestion/suggestion.pl DataTables_table_3_/cgi-bin/koha/suggestion/suggestion.pl If you move all the suggestions from Accepted to Rejected, a shift will give: Pending (#table_1), Rejected (#table_2) And the previous state from the "Accepted" tab will be used for "Rejected" Test plan: Confirm the above, have several tabs then remove one by moving the all suggestions to an other tab. Test the other features on the edit and list views: change status, update manager, etc. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Pushed for 24.11! Well done everyone, thank you! Doesn't apply clean to 24.05.x, no backport. |