Bug 38183 - Can't set suggestion manager when there are multiple tabs
Summary: Can't set suggestion manager when there are multiple tabs
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Lucas Gass (lukeg)
QA Contact: Jonathan Druart
URL:
Keywords: rel_24_05_candidate
: 38111 (view as bug list)
Depends on: 35329
Blocks: 38192
  Show dependency treegraph
 
Reported: 2024-10-15 23:11 UTC by Lucas Gass (lukeg)
Modified: 2024-10-18 12:27 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 38183: Get the active tab number from data-attribute (3.12 KB, patch)
2024-10-15 23:51 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 38183: Get the active tab number from data-attribute (3.18 KB, patch)
2024-10-17 02:10 UTC, Phil Ringnalda
Details | Diff | Splinter Review
Bug 38183: Get the active tab number from data-attribute (3.25 KB, patch)
2024-10-17 10:12 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2024-10-15 23:11:04 UTC
To recreate:

1. Have more than 1 staff member who can manage suggestions 
2. Create some suggestions
3. Move some suggestions to different statuses (Pending/Accepted/Rejected) so you have multiple tabs on the "Suggestions management" page.
4. Go to the first tab, check some suggestions, and click "Select manager" under "Update manager".
5. Pick a new manager, notice nothing changes on that tab. 
6. Now look at the last tab in your list of tabs, see the suggestion manager has been set incorrectly to the last tab. 

You may also notice another JS error in the console. I filed Bug 38182 about that.
Comment 1 Lucas Gass (lukeg) 2024-10-15 23:51:34 UTC Comment hidden (obsolete)
Comment 2 Lucas Gass (lukeg) 2024-10-16 12:53:03 UTC
*** Bug 38111 has been marked as a duplicate of this bug. ***
Comment 3 Phil Ringnalda 2024-10-17 02:10:59 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2024-10-17 10:12:40 UTC
Created attachment 172859 [details] [review]
Bug 38183: Get the active tab number from data-attribute

To test:

1. Have more than 1 staff member who can manage suggestions
2. Create some suggestions
3. Move some suggestions to different statuses (Pending/Accepted/Rejected) so you have multiple tabs on the "Suggestions management" page.
4. Go to the first tab, check some suggestions, and click "Select manager" under "Update manager".
5. Pick a new manager, notice nothing changes on that tab.
6. Now look at the last tab in your list of tabs, see the suggestion manager has been set incorrectly to the last tab.
7. APPLY PATCH
8. Try 4-5 again. The manager should be selected correctly.
9. Try setting the manaager from every tab, making sure it works right.

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Jonathan Druart 2024-10-17 10:13:30 UTC
Just got hit by that one. I had another approach but I will adjust the on top of yours.

bug 38192
Comment 6 Katrin Fischer 2024-10-18 12:27:51 UTC
Pushed for 24.11!

Well done everyone, thank you!