Summary: | Remove old version of Bootstrap JS left behind during upgrade | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | RESOLVED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, jonathan.druart, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.11.00
|
|
Circulation function: | |||
Bug Depends on: | 35402 | ||
Bug Blocks: | |||
Attachments: |
Bug 38197: Remove old version of Bootstrap JS left behind during upgrade
Bug 38197: Remove old version of Bootstrap JS left behind during upgrade Bug 38197: Remove old version of Bootstrap JS left behind during upgrade |
Description
Owen Leonard
2024-10-17 14:39:38 UTC
Oh I'm looking at the Bootstrap file which was left behind and should have been removed! Created attachment 172892 [details] [review] Bug 38197: Remove old version of Bootstrap JS left behind during upgrade This patch removes an old version of Bootstrap JS which should have been removed by Bug 35402. The correct Bootstrap JS file is at koha-tmpl/opac-tmpl/lib/bootstrap/js/bootstrap.bundle.min.js This patch should have no effect on any OPAC functionality. Bootstrap-related features should still work: Dropdown menus, modals, etc. Created attachment 172926 [details] [review] Bug 38197: Remove old version of Bootstrap JS left behind during upgrade This patch removes an old version of Bootstrap JS which should have been removed by Bug 35402. The correct Bootstrap JS file is at koha-tmpl/opac-tmpl/lib/bootstrap/js/bootstrap.bundle.min.js This patch should have no effect on any OPAC functionality. Bootstrap-related features should still work: Dropdown menus, modals, etc. Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD): 1. No OPAC files are using the file removed (before and after the patch): git grep bootstrap/lib/bootstrap/bootstrap.bundle.min.js Not sure why the dir structure is not the same (extra 'js'), but that's for another day anyway koha-tmpl/opac-tmpl /lib/bootstrap/js/bootstrap.bundle.min.js koha-tmpl/intranet-tmpl/lib/bootstrap/bootstrap.bundle.min.js Created attachment 173018 [details] [review] Bug 38197: Remove old version of Bootstrap JS left behind during upgrade This patch removes an old version of Bootstrap JS which should have been removed by Bug 35402. The correct Bootstrap JS file is at koha-tmpl/opac-tmpl/lib/bootstrap/js/bootstrap.bundle.min.js This patch should have no effect on any OPAC functionality. Bootstrap-related features should still work: Dropdown menus, modals, etc. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed for 24.11! Well done everyone, thank you! |