Bug 38197 - Remove old version of Bootstrap JS left behind during upgrade
Summary: Remove old version of Bootstrap JS left behind during upgrade
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on: 35402
Blocks:
  Show dependency treegraph
 
Reported: 2024-10-17 14:39 UTC by Owen Leonard
Modified: 2024-10-21 13:13 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 38197: Remove old version of Bootstrap JS left behind during upgrade (79.55 KB, patch)
2024-10-17 15:04 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38197: Remove old version of Bootstrap JS left behind during upgrade (79.60 KB, patch)
2024-10-17 18:54 UTC, David Nind
Details | Diff | Splinter Review
Bug 38197: Remove old version of Bootstrap JS left behind during upgrade (79.68 KB, patch)
2024-10-21 09:23 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2024-10-17 14:39:38 UTC
Probably as a consequence of the delay between my work on the Bootstrap upgrade and the OPAC and the staff interface, the version of Bootstrap in the OPAC is behind the version in the staff interface.

These should be the same.
Comment 1 Owen Leonard 2024-10-17 14:41:11 UTC
Oh I'm looking at the Bootstrap file which was left behind and should have been removed!
Comment 2 Owen Leonard 2024-10-17 15:04:52 UTC
Created attachment 172892 [details] [review]
Bug 38197: Remove old version of Bootstrap JS left behind during upgrade

This patch removes an old version of Bootstrap JS which should have been
removed by Bug 35402. The correct Bootstrap JS file is at
koha-tmpl/opac-tmpl/lib/bootstrap/js/bootstrap.bundle.min.js

This patch should have no effect on any OPAC functionality.
Bootstrap-related features should still work: Dropdown menus, modals,
etc.
Comment 3 David Nind 2024-10-17 18:54:05 UTC
Created attachment 172926 [details] [review]
Bug 38197: Remove old version of Bootstrap JS left behind during upgrade

This patch removes an old version of Bootstrap JS which should have been
removed by Bug 35402. The correct Bootstrap JS file is at
koha-tmpl/opac-tmpl/lib/bootstrap/js/bootstrap.bundle.min.js

This patch should have no effect on any OPAC functionality.
Bootstrap-related features should still work: Dropdown menus, modals,
etc.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2024-10-17 18:57:27 UTC
Testing notes (using KTD):

1. No OPAC files are using the file removed (before and after the patch): 
   git grep bootstrap/lib/bootstrap/bootstrap.bundle.min.js
Comment 5 Jonathan Druart 2024-10-21 09:23:31 UTC
Not sure why the dir structure is not the same (extra 'js'), but that's for another day anyway

koha-tmpl/opac-tmpl    /lib/bootstrap/js/bootstrap.bundle.min.js
koha-tmpl/intranet-tmpl/lib/bootstrap/bootstrap.bundle.min.js
Comment 6 Jonathan Druart 2024-10-21 09:23:51 UTC
Created attachment 173018 [details] [review]
Bug 38197: Remove old version of Bootstrap JS left behind during upgrade

This patch removes an old version of Bootstrap JS which should have been
removed by Bug 35402. The correct Bootstrap JS file is at
koha-tmpl/opac-tmpl/lib/bootstrap/js/bootstrap.bundle.min.js

This patch should have no effect on any OPAC functionality.
Bootstrap-related features should still work: Dropdown menus, modals,
etc.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 7 Katrin Fischer 2024-10-21 13:13:00 UTC
Pushed for 24.11!

Well done everyone, thank you!