Summary: | New bibliographic record in non-default framework opens in default on first edit | ||
---|---|---|---|
Product: | Koha | Reporter: | Phil Ringnalda <phil> |
Component: | Cataloging | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | Needs documenting --- | QA Contact: | Emily Lamancusa (emlam) <emily.lamancusa> |
Severity: | critical | ||
Priority: | P5 - low | CC: | emily.lamancusa, fridolin.somers, jonathan.druart, lucas, m.de.rooy, martin.renvoize, mnero |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.11.00,24.05.05
|
|
Circulation function: | |||
Bug Depends on: | 37947, 38076 | ||
Bug Blocks: | |||
Attachments: |
Bug 38211: frameworkcode must be set before read
Bug 38211: frameworkcode must be set before read Bug 38211: frameworkcode must be set before read |
Description
Phil Ringnalda
2024-10-18 19:41:56 UTC
Actually, let's call that major. Since I was looking for it and looking for the once-only thing, I wasn't saving the record on the first opening of the editor, but in general it's not obvious that you've opened a record in a framework other than the one it should have, so you'll just save it, moving it from the framework it had into the Default framework, which can be a cause of dataloss depending on your frameworks. Created attachment 173019 [details] [review] Bug 38211: frameworkcode must be set before read It's a stupid global variable, we MUST have this init line BEFORE we read it! Test plan: See the other bugs linked with this one, confirm the test plan for all of them still pass. Test plan for this specific bug report: 1. Cataloging - New record -> Audio Cassettes, CDs 2. Fill in the required fields and save 3. Switch to 'Normal', Edit - Edit record 4. Note that 001 and 003 are not visible, and the Settings menu has a checkmark by Audio Cassettes, CDs 5. Click the browser Back button, then Edit - Edit record 6. Note that 001 and 003 are not visible, and the Settings menu has a checkmark by Audio Cassettes, CDs Created attachment 173048 [details] [review] Bug 38211: frameworkcode must be set before read It's a stupid global variable, we MUST have this init line BEFORE we read it! Test plan: See the other bugs linked with this one, confirm the test plan for all of them still pass. Test plan for this specific bug report: 1. Cataloging - New record -> Audio Cassettes, CDs 2. Fill in the required fields and save 3. Switch to 'Normal', Edit - Edit record 4. Note that 001 and 003 are not visible, and the Settings menu has a checkmark by Audio Cassettes, CDs 5. Click the browser Back button, then Edit - Edit record 6. Note that 001 and 003 are not visible, and the Settings menu has a checkmark by Audio Cassettes, CDs Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Created attachment 173053 [details] [review] Bug 38211: frameworkcode must be set before read It's a stupid global variable, we MUST have this init line BEFORE we read it! Test plan: See the other bugs linked with this one, confirm the test plan for all of them still pass. Test plan for this specific bug report: 1. Cataloging - New record -> Audio Cassettes, CDs 2. Fill in the required fields and save 3. Switch to 'Normal', Edit - Edit record 4. Note that 001 and 003 are not visible, and the Settings menu has a checkmark by Audio Cassettes, CDs 5. Click the browser Back button, then Edit - Edit record 6. Note that 001 and 003 are not visible, and the Settings menu has a checkmark by Audio Cassettes, CDs Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Oof...this script and its globals. Thanks, Jonathan! Passing QA (also tidied inline) Thanks for the quick work here, Jonathan, Brendan and Emily! Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.05 |